Re: [PATCH 1/2] ASoC: imx-wm8958: add imx-wm8958 machine driver

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1191 bytes --]

On Wed, Dec 09, 2015 at 11:34:52AM +0800, Zidan Wang wrote:
> On Tue, Dec 08, 2015 at 12:47:13PM +0000, Mark Brown wrote:
> > On Tue, Dec 08, 2015 at 05:40:13PM +0800, Zidan Wang wrote:

> > > + - aifx-continuous-clock   : If present, bit clock will be continuous.
> > > +			     Otherwise, dai bit clocks can be be gated
> > > +			     (disabled) when the dai is not sending or
> > > +			     receiving PCM data in a frame.

> > Why are these selectable in the machine driver?

> I have tested and found that sai<->aif1 can support "i2s" "left_j"
> "dsp_a" "dsp_b" format, and can support cpu dai master and slave
> mode. But I haven't tested voice dai and bt dai because of hardware
> limitation. I just using sai<->aif2 to test aif2.

> So I want to configure the dai format from device tree. And there is
> a help function snd_soc_of_parse_daifmt for me to do this, so I add
> these selectable to the machine driver.

This really sounds like the best thing to do here is to just leave this
out of the upstream submission then add the support for the voice and BT
link when you've got the configuration worked out.  You'll most likely
find there's only one possible configuration anyway.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]