* Re: ASoC: rt5514: add rt5514 SPI driver
@ 2016-06-16 10:49 Dan Carpenter
0 siblings, 0 replies; only message in thread
From: Dan Carpenter @ 2016-06-16 10:49 UTC (permalink / raw)
To: oder_chiou; +Cc: alsa-devel
Hello Oder Chiou,
This is a semi-automatic email about new static checker warnings.
The patch 6eebf35b0e4a: "ASoC: rt5514: add rt5514 SPI driver" from
Jun 6, 2016, leads to the following Smatch complaint:
sound/soc/codecs/rt5514-spi.c:87 rt5514_spi_copy_work()
warn: variable dereferenced before check 'rt5514_dsp->substream' (see line 83)
sound/soc/codecs/rt5514-spi.c
82 container_of(work, struct rt5514_dsp, copy_work.work);
83 struct snd_pcm_runtime *runtime = rt5514_dsp->substream->runtime;
^^^^^^^^^^^^^^^^^^^^^^^
Dereference.
84 size_t period_bytes, truncated_bytes = 0;
85
86 mutex_lock(&rt5514_dsp->dma_lock);
87 if (!rt5514_dsp->substream) {
^^^^^^^^^^^^^^^^^^^^^
Checked too late.
88 dev_err(rt5514_dsp->dev, "No pcm substream\n");
89 goto done;
regards,
dan carpenter
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2016-06-16 10:49 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-16 10:49 ASoC: rt5514: add rt5514 SPI driver Dan Carpenter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox