From: Nicolin Chen <nicoleotsuka@gmail.com>
To: weiyj_lk@163.com
Cc: Brian Austin <brian.austin@cirrus.com>,
Paul Handrigan <Paul.Handrigan@cirrus.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
Wei Yongjun <yongjun_wei@trendmicro.com.cn>,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [alsa-devel] [PATCH -next] ASoC: cs53l30: Fix non static symbol warnings
Date: Fri, 17 Jun 2016 10:35:02 -0700 [thread overview]
Message-ID: <20160617173501.GA21670@Asurada-Nvidia> (raw)
In-Reply-To: <1466184120-13062-1-git-send-email-weiyj_lk@163.com>
On Fri, Jun 17, 2016 at 05:22:00PM +0000, weiyj_lk@163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fixes the following sparse warnings:
>
> sound/soc/codecs/cs53l30.c:182:20: warning:
> symbol 'input1_sel_values' was not declared. Should it be static?
> sound/soc/codecs/cs53l30.c:202:20: warning:
> symbol 'input2_sel_values' was not declared. Should it be static?
> sound/soc/codecs/cs53l30.c:734:20: warning:
> symbol 'cs53l30_src_rates' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
> ---
> sound/soc/codecs/cs53l30.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c
> index 714e579..a9949ad 100644
> --- a/sound/soc/codecs/cs53l30.c
> +++ b/sound/soc/codecs/cs53l30.c
> @@ -179,7 +179,7 @@ static const char * const input1_sel_text[] = {
> "DMIC1 Off ADC1 Off",
> };
>
> -unsigned int const input1_sel_values[] = {
> +static unsigned int const input1_sel_values[] = {
> CS53L30_CH_TYPE,
> CS53L30_ADCxB_PDN | CS53L30_CH_TYPE,
> CS53L30_ADCxA_PDN | CS53L30_CH_TYPE,
> @@ -199,7 +199,7 @@ static const char * const input2_sel_text[] = {
> "DMIC2 Off ADC2 Off",
> };
>
> -unsigned int const input2_sel_values[] = {
> +static unsigned int const input2_sel_values[] = {
> 0x0,
> CS53L30_ADCxB_PDN,
> CS53L30_ADCxA_PDN,
> @@ -731,7 +731,7 @@ static int cs53l30_set_tristate(struct snd_soc_dai *dai, int tristate)
> CS53L30_ASP_3ST_MASK, val);
> }
>
> -unsigned int const cs53l30_src_rates[] = {
> +static unsigned int const cs53l30_src_rates[] = {
> 8000, 11025, 12000, 16000, 22050, 24000, 32000, 44100, 48000
> };
>
>
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
next prev parent reply other threads:[~2016-06-17 17:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-17 17:22 [PATCH -next] ASoC: cs53l30: Fix non static symbol warnings weiyj_lk
2016-06-17 17:35 ` Nicolin Chen [this message]
2016-06-17 18:53 ` Handrigan, Paul
2016-06-21 18:52 ` Applied "ASoC: cs53l30: Fix non static symbol warnings" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160617173501.GA21670@Asurada-Nvidia \
--to=nicoleotsuka@gmail.com \
--cc=Paul.Handrigan@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=brian.austin@cirrus.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
--cc=weiyj_lk@163.com \
--cc=yongjun_wei@trendmicro.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox