* Re: [alsa-devel] [PATCH -next] ASoC: cs53l30: Fix non static symbol warnings
2016-06-17 17:22 [PATCH -next] ASoC: cs53l30: Fix non static symbol warnings weiyj_lk
@ 2016-06-17 17:35 ` Nicolin Chen
2016-06-17 18:53 ` Handrigan, Paul
2016-06-21 18:52 ` Applied "ASoC: cs53l30: Fix non static symbol warnings" to the asoc tree Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Nicolin Chen @ 2016-06-17 17:35 UTC (permalink / raw)
To: weiyj_lk
Cc: Brian Austin, Paul Handrigan, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai, Wei Yongjun, alsa-devel,
linux-kernel
On Fri, Jun 17, 2016 at 05:22:00PM +0000, weiyj_lk@163.com wrote:
> From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
> Fixes the following sparse warnings:
>
> sound/soc/codecs/cs53l30.c:182:20: warning:
> symbol 'input1_sel_values' was not declared. Should it be static?
> sound/soc/codecs/cs53l30.c:202:20: warning:
> symbol 'input2_sel_values' was not declared. Should it be static?
> sound/soc/codecs/cs53l30.c:734:20: warning:
> symbol 'cs53l30_src_rates' was not declared. Should it be static?
>
> Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
> ---
> sound/soc/codecs/cs53l30.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c
> index 714e579..a9949ad 100644
> --- a/sound/soc/codecs/cs53l30.c
> +++ b/sound/soc/codecs/cs53l30.c
> @@ -179,7 +179,7 @@ static const char * const input1_sel_text[] = {
> "DMIC1 Off ADC1 Off",
> };
>
> -unsigned int const input1_sel_values[] = {
> +static unsigned int const input1_sel_values[] = {
> CS53L30_CH_TYPE,
> CS53L30_ADCxB_PDN | CS53L30_CH_TYPE,
> CS53L30_ADCxA_PDN | CS53L30_CH_TYPE,
> @@ -199,7 +199,7 @@ static const char * const input2_sel_text[] = {
> "DMIC2 Off ADC2 Off",
> };
>
> -unsigned int const input2_sel_values[] = {
> +static unsigned int const input2_sel_values[] = {
> 0x0,
> CS53L30_ADCxB_PDN,
> CS53L30_ADCxA_PDN,
> @@ -731,7 +731,7 @@ static int cs53l30_set_tristate(struct snd_soc_dai *dai, int tristate)
> CS53L30_ASP_3ST_MASK, val);
> }
>
> -unsigned int const cs53l30_src_rates[] = {
> +static unsigned int const cs53l30_src_rates[] = {
> 8000, 11025, 12000, 16000, 22050, 24000, 32000, 44100, 48000
> };
>
>
>
> _______________________________________________
> Alsa-devel mailing list
> Alsa-devel@alsa-project.org
> http://mailman.alsa-project.org/mailman/listinfo/alsa-devel
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH -next] ASoC: cs53l30: Fix non static symbol warnings
2016-06-17 17:22 [PATCH -next] ASoC: cs53l30: Fix non static symbol warnings weiyj_lk
2016-06-17 17:35 ` [alsa-devel] " Nicolin Chen
@ 2016-06-17 18:53 ` Handrigan, Paul
2016-06-21 18:52 ` Applied "ASoC: cs53l30: Fix non static symbol warnings" to the asoc tree Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Handrigan, Paul @ 2016-06-17 18:53 UTC (permalink / raw)
To: weiyj_lk@163.com, Austin, Brian, Liam Girdwood, Mark Brown,
Jaroslav Kysela, Takashi Iwai
Cc: Wei Yongjun, alsa-devel@alsa-project.org,
linux-kernel@vger.kernel.org
On 6/17/16, 12:22 PM, "weiyj_lk@163.com" <weiyj_lk@163.com> wrote:
>From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>
>Fixes the following sparse warnings:
>
>sound/soc/codecs/cs53l30.c:182:20: warning:
> symbol 'input1_sel_values' was not declared. Should it be static?
>sound/soc/codecs/cs53l30.c:202:20: warning:
> symbol 'input2_sel_values' was not declared. Should it be static?
>sound/soc/codecs/cs53l30.c:734:20: warning:
> symbol 'cs53l30_src_rates' was not declared. Should it be static?
>
>Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
>---
> sound/soc/codecs/cs53l30.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c
>index 714e579..a9949ad 100644
>--- a/sound/soc/codecs/cs53l30.c
>+++ b/sound/soc/codecs/cs53l30.c
>@@ -179,7 +179,7 @@ static const char * const input1_sel_text[] = {
> "DMIC1 Off ADC1 Off",
> };
>
>-unsigned int const input1_sel_values[] = {
>+static unsigned int const input1_sel_values[] = {
> CS53L30_CH_TYPE,
> CS53L30_ADCxB_PDN | CS53L30_CH_TYPE,
> CS53L30_ADCxA_PDN | CS53L30_CH_TYPE,
>@@ -199,7 +199,7 @@ static const char * const input2_sel_text[] = {
> "DMIC2 Off ADC2 Off",
> };
>
>-unsigned int const input2_sel_values[] = {
>+static unsigned int const input2_sel_values[] = {
> 0x0,
> CS53L30_ADCxB_PDN,
> CS53L30_ADCxA_PDN,
>@@ -731,7 +731,7 @@ static int cs53l30_set_tristate(struct snd_soc_dai
>*dai, int tristate)
> CS53L30_ASP_3ST_MASK, val);
> }
>
>-unsigned int const cs53l30_src_rates[] = {
>+static unsigned int const cs53l30_src_rates[] = {
> 8000, 11025, 12000, 16000, 22050, 24000, 32000, 44100, 48000
> };
Acked-by: Paul Handrigan <Paul.Handrigan@cirrus.com>
^ permalink raw reply [flat|nested] 4+ messages in thread* Applied "ASoC: cs53l30: Fix non static symbol warnings" to the asoc tree
2016-06-17 17:22 [PATCH -next] ASoC: cs53l30: Fix non static symbol warnings weiyj_lk
2016-06-17 17:35 ` [alsa-devel] " Nicolin Chen
2016-06-17 18:53 ` Handrigan, Paul
@ 2016-06-21 18:52 ` Mark Brown
2 siblings, 0 replies; 4+ messages in thread
From: Mark Brown @ 2016-06-21 18:52 UTC (permalink / raw)
To: Wei Yongjun; +Cc: Nicolin Chen, Paul Handrigan, Mark Brown, Brian Austin
The patch
ASoC: cs53l30: Fix non static symbol warnings
has been applied to the asoc tree at
git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From ee85be8c9b5277a50bf6491c30b2736a5562331b Mon Sep 17 00:00:00 2001
From: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Date: Fri, 17 Jun 2016 17:22:00 +0000
Subject: [PATCH] ASoC: cs53l30: Fix non static symbol warnings
Fixes the following sparse warnings:
sound/soc/codecs/cs53l30.c:182:20: warning:
symbol 'input1_sel_values' was not declared. Should it be static?
sound/soc/codecs/cs53l30.c:202:20: warning:
symbol 'input2_sel_values' was not declared. Should it be static?
sound/soc/codecs/cs53l30.c:734:20: warning:
symbol 'cs53l30_src_rates' was not declared. Should it be static?
Signed-off-by: Wei Yongjun <yongjun_wei@trendmicro.com.cn>
Acked-by: Nicolin Chen <nicoleotsuka@gmail.com>
Acked-by: Paul Handrigan <Paul.Handrigan@cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
sound/soc/codecs/cs53l30.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/cs53l30.c b/sound/soc/codecs/cs53l30.c
index 384a3f79f1c5..a5976f3b589a 100644
--- a/sound/soc/codecs/cs53l30.c
+++ b/sound/soc/codecs/cs53l30.c
@@ -180,7 +180,7 @@ static const char * const input1_sel_text[] = {
"DMIC1 Off ADC1 Off",
};
-unsigned int const input1_sel_values[] = {
+static unsigned int const input1_sel_values[] = {
CS53L30_CH_TYPE,
CS53L30_ADCxB_PDN | CS53L30_CH_TYPE,
CS53L30_ADCxA_PDN | CS53L30_CH_TYPE,
@@ -200,7 +200,7 @@ static const char * const input2_sel_text[] = {
"DMIC2 Off ADC2 Off",
};
-unsigned int const input2_sel_values[] = {
+static unsigned int const input2_sel_values[] = {
0x0,
CS53L30_ADCxB_PDN,
CS53L30_ADCxA_PDN,
@@ -738,7 +738,7 @@ static int cs53l30_set_tristate(struct snd_soc_dai *dai, int tristate)
CS53L30_ASP_3ST_MASK, val);
}
-unsigned int const cs53l30_src_rates[] = {
+static unsigned int const cs53l30_src_rates[] = {
8000, 11025, 12000, 16000, 22050, 24000, 32000, 44100, 48000
};
--
2.8.1
^ permalink raw reply related [flat|nested] 4+ messages in thread