From: Mark Brown <broonie@kernel.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
Linux-ALSA <alsa-devel@alsa-project.org>,
Simon <horms@verge.net.au>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 1/7] ASoC: simple-card-utils: add asoc_simple_card_set_dailink_name()
Date: Fri, 8 Jul 2016 14:43:33 +0200 [thread overview]
Message-ID: <20160708124333.GW6247@sirena.org.uk> (raw)
In-Reply-To: <87y45flguw.wl%kuninori.morimoto.gx@renesas.com>
[-- Attachment #1: Type: text/plain, Size: 347 bytes --]
On Wed, Jul 06, 2016 at 10:01:27AM +0900, Kuninori Morimoto wrote:
> + if (name) {
> + ret = 0;
> +
> + dai_link->name =
> + dai_link->stream_name = name;
> + }
This code is unclear - it's valid C but the line break in the middle of
the set of assignments makes it look like the first assignment is an
error. This should be two assignments.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
next prev parent reply other threads:[~2016-07-08 12:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 1:06 [PATCH 0/7] ASoC: simple: dailink_name and card_name Kuninori Morimoto
2016-07-06 1:01 ` [PATCH 1/7] ASoC: simple-card-utils: add asoc_simple_card_set_dailink_name() Kuninori Morimoto
2016-07-08 12:43 ` Mark Brown [this message]
2016-07-06 1:09 ` [PATCH 2/7] ASoC: simple-card: use asoc_simple_card_parse_dailink_name() Kuninori Morimoto
2016-07-16 12:04 ` Applied "ASoC: simple-card: use asoc_simple_card_parse_dailink_name()" to the asoc tree Mark Brown
2016-07-06 1:09 ` [PATCH 3/7] ASoC: rsrc-card: use asoc_simple_card_parse_dailink_name() Kuninori Morimoto
2016-07-16 12:05 ` Applied "ASoC: rsrc-card: use asoc_simple_card_parse_dailink_name()" to the asoc tree Mark Brown
2016-07-06 1:09 ` [PATCH 4/7] ASoC: rsrc-card: use asoc_simple_dai instead of rsrc_card_dai Kuninori Morimoto
2016-07-16 12:05 ` Applied "ASoC: rsrc-card: use asoc_simple_dai instead of rsrc_card_dai" to the asoc tree Mark Brown
2016-07-06 1:10 ` [PATCH 5/7] ASoC: simple-card-utils: add asoc_simple_card_parse_card_name() Kuninori Morimoto
2016-07-16 12:04 ` Applied "ASoC: simple-card-utils: add asoc_simple_card_parse_card_name()" to the asoc tree Mark Brown
2016-07-06 1:11 ` [PATCH 6/7] ASoC: simple-card: use asoc_simple_card_parse_card_name() Kuninori Morimoto
2016-07-06 1:11 ` [PATCH 7/7] ASoC: rsrc-card: " Kuninori Morimoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160708124333.GW6247@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox