From: Vinod Koul <vinod.koul@intel.com>
To: Takashi Iwai <tiwai@suse.de>
Cc: liam.r.girdwood@linux.intel.com, patches.audio@intel.com,
alsa-devel@alsa-project.org, broonie@kernel.org
Subject: Re: [PATCH v3 1/5] ALSA: hda - move bus_parse_capabilities to core
Date: Thu, 4 Aug 2016 07:26:56 +0530 [thread overview]
Message-ID: <20160804015656.GY9681@localhost> (raw)
In-Reply-To: <s5hk2fx96mu.wl-tiwai@suse.de>
On Wed, Aug 03, 2016 at 06:09:13PM +0200, Takashi Iwai wrote:
> > + dev_dbg(bus->dev, "Capability version: 0x%x\n",
> > + ((cur_cap & AZX_CAP_HDR_VER_MASK) >> AZX_CAP_HDR_VER_OFF));
>
> Too much indentation. Also the parentheses are superfluous (unlike
> below).
Okay, I didn't modify this piece and copied. Will update this.
>
> > +
> > + dev_dbg(bus->dev, "HDA capability ID: 0x%x\n",
> > + (cur_cap & AZX_CAP_HDR_ID_MASK) >> AZX_CAP_HDR_ID_OFF);
>
> Too much indentation.
ok
> > + /* read the offset of next capabiity */
>
> A typo.
ok
--
~Vinod
next prev parent reply other threads:[~2016-08-04 1:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-03 16:06 [PATCH v3 0/5] ALSA - hda: Add support for link audio time reporting Vinod Koul
2016-08-03 16:06 ` [PATCH v3 1/5] ALSA: hda - move bus_parse_capabilities to core Vinod Koul
2016-08-03 16:09 ` Takashi Iwai
2016-08-04 1:56 ` Vinod Koul [this message]
2016-08-03 16:06 ` [PATCH v3 2/5] ALSA: convert users to core bus_parse_capabilities Vinod Koul
2016-08-09 12:44 ` Applied "ALSA: convert users to core bus_parse_capabilities" to the asoc tree Mark Brown
2016-08-03 16:06 ` [PATCH v3 3/5] ALSA - Ext hda: remove bus_parse_capabilities Vinod Koul
2016-08-09 12:44 ` Applied "ALSA - Ext hda: remove bus_parse_capabilities" to the asoc tree Mark Brown
2016-08-03 16:06 ` [PATCH v3 4/5] ALSA - hda: Add support for parsing new HDA capabilities Vinod Koul
2016-08-03 16:11 ` Takashi Iwai
2016-08-04 2:00 ` Vinod Koul
2016-08-04 5:51 ` Vinod Koul
2016-08-04 5:46 ` Takashi Iwai
2016-08-03 16:06 ` [PATCH v3 5/5] ALSA - hda: Add support for link audio time reporting Vinod Koul
2016-08-03 16:21 ` Takashi Iwai
2016-08-04 2:00 ` Vinod Koul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160804015656.GY9681@localhost \
--to=vinod.koul@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=liam.r.girdwood@linux.intel.com \
--cc=patches.audio@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox