Re: [PATCH v3 4/5] ALSA - hda: Add support for parsing new HDA capabilities

[Vinod Koul <vinod.koul@intel.com>]

On Wed, Aug 03, 2016 at 06:11:28PM +0200, Takashi Iwai wrote:
> On Wed, 03 Aug 2016 18:06:13 +0200,
> Vinod Koul wrote:
> > 
> > --- a/sound/pci/hda/hda_intel.c
> > +++ b/sound/pci/hda/hda_intel.c
> > @@ -1655,6 +1655,22 @@ static int azx_first_init(struct azx *chip)
> >  		return -ENXIO;
> >  	}
> >  
> > +	if (IS_SKL_PLUS(pci))
> > +		snd_hdac_bus_parse_capabilities(bus);
> > +
> > +	/*
> > +	 * Some Intel CPUs has always running timer (ART) feature and
> > +	 * controller may have Global time sync reporting capability, so
> > +	 * check both of these before declaring synchronized time reporting
> > +	 * capability SNDRV_PCM_INFO_HAS_LINK_SYNCHRONIZED_ATIME
> > +	 */
> > +	chip->gts_present = false;
> > +
> > +#ifdef CONFIG_X86
> > +	if ((bus->ppcap && boot_cpu_has(X86_FEATURE_ART)))
> 
> Superfluous parentheses.
> Also, don't we need to include asm/cpufeature.h?

Its somehow included, I will check that part as well

-- 
~Vinod