From: Mark Brown <broonie@kernel.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>, Simon <horms@verge.net.au>
Subject: Re: [PATCH 7/8] ASoC: rsnd: Request/Release DMA channel each time
Date: Tue, 25 Oct 2016 15:02:31 +0100 [thread overview]
Message-ID: <20161025140231.GU17252@sirena.org.uk> (raw)
In-Reply-To: <87y41db7c0.wl%kuninori.morimoto.gx@renesas.com>
[-- Attachment #1.1: Type: text/plain, Size: 570 bytes --]
On Tue, Oct 25, 2016 at 12:37:59AM +0000, Kuninori Morimoto wrote:
> Current Renesas Sound driver requests DMA channel when .probe timing,
> and release it when .remove timing. And use DMA on .start/.stop
> But, Audio DMAC power ON was handled when request timing (= .probe),
> and power OFF was when release timing (= .remove).
> This means Audio DMAC power is always ON during driver was enabled.
> This patch fixup to request/release DMA channel each time.
Isn't this something which should be handled by better power management
in the DMA driver rather than this?
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 473 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2016-10-25 14:02 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-25 0:35 [PATCH 0/8] ASoC: rsnd: DMA power fix and IOMMU support Kuninori Morimoto
2016-10-25 0:35 ` [PATCH 1/8] ASoC: rsnd: depends on OF Kuninori Morimoto
2016-10-25 13:28 ` Mark Brown
2016-10-26 0:00 ` Kuninori Morimoto
2016-10-26 15:12 ` Applied "ASoC: rsnd: depends on OF" to the asoc tree Mark Brown
2016-10-25 0:36 ` [PATCH 2/8] ASoC: rsnd: remove non DT support for DMA Kuninori Morimoto
2016-10-25 19:24 ` Applied "ASoC: rsnd: remove non DT support for DMA" to the asoc tree Mark Brown
2016-10-25 0:36 ` [PATCH 3/8] ASoC: rsnd: don't use devm_request_irq() for SSI Kuninori Morimoto
2016-10-25 19:23 ` Applied "ASoC: rsnd: don't use devm_request_irq() for SSI" to the asoc tree Mark Brown
2016-10-25 0:36 ` [PATCH 4/8] ASoC: rsnd: remove rsnd_dma_detach() Kuninori Morimoto
2016-10-25 19:23 ` Applied "ASoC: rsnd: remove rsnd_dma_detach()" to the asoc tree Mark Brown
2016-10-25 0:37 ` [PATCH 5/8] ASoC: rsnd: don't call unneeded of_node_put() on dma.c Kuninori Morimoto
2016-10-25 19:23 ` Applied "ASoC: rsnd: don't call unneeded of_node_put() on dma.c" to the asoc tree Mark Brown
2016-10-25 0:37 ` [PATCH 6/8] ASoC: rsnd: add nolock_start/stop callback Kuninori Morimoto
2016-10-25 19:23 ` Applied "ASoC: rsnd: add nolock_start/stop callback" to the asoc tree Mark Brown
2016-10-25 0:37 ` [PATCH 7/8] ASoC: rsnd: Request/Release DMA channel each time Kuninori Morimoto
2016-10-25 14:02 ` Mark Brown [this message]
2016-10-25 23:55 ` Kuninori Morimoto
2016-10-25 0:38 ` [PATCH 8/8] ASoC: rsnd: use dma_sync_single_for_xxx() for IOMMU Kuninori Morimoto
2016-11-22 17:26 ` Applied "ASoC: rsnd: use dma_sync_single_for_xxx() for IOMMU" to the asoc tree Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161025140231.GU17252@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=horms@verge.net.au \
--cc=kuninori.morimoto.gx@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox