Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Mark Brown <broonie@kernel.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Linux-ALSA <alsa-devel@alsa-project.org>,
	Mark Brown <broonie@kernel.org>, Simon <horms@verge.net.au>
Subject: Applied "ASoC: rsnd: remove rsnd_dma_detach()" to the asoc tree
Date: Tue, 25 Oct 2016 20:23:46 +0100	[thread overview]
Message-ID: <E1bz7K6-0004oK-Ka@debutante> (raw)
In-Reply-To: <8737jlcly4.wl%kuninori.morimoto.gx@renesas.com>

The patch

   ASoC: rsnd: remove rsnd_dma_detach()

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From dae4b83295ae50a86b5e3c60e7b6e2c597a1b69d Mon Sep 17 00:00:00 2001
From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Date: Tue, 25 Oct 2016 00:36:56 +0000
Subject: [PATCH] ASoC: rsnd: remove rsnd_dma_detach()

DMA mod is now connected to stream via rsnd_dai_connect().
This means DMA mod can use .remove for its clearance.
rsnd_dma_detach() is no longer needed.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/sh/rcar/dma.c  | 11 -----------
 sound/soc/sh/rcar/rsnd.h |  1 -
 sound/soc/sh/rcar/ssi.c  |  2 --
 3 files changed, 14 deletions(-)

diff --git a/sound/soc/sh/rcar/dma.c b/sound/soc/sh/rcar/dma.c
index e0761cac0ab7..c85a55111392 100644
--- a/sound/soc/sh/rcar/dma.c
+++ b/sound/soc/sh/rcar/dma.c
@@ -698,17 +698,6 @@ int rsnd_dma_attach(struct rsnd_dai_stream *io, struct rsnd_mod *mod,
 	return 0;
 }
 
-void rsnd_dma_detach(struct rsnd_mod *mod, struct rsnd_mod **dma_mod)
-{
-	if (*dma_mod) {
-		struct rsnd_priv *priv = rsnd_mod_to_priv(mod);
-		struct device *dev = rsnd_priv_to_dev(priv);
-
-		devm_kfree(dev, *dma_mod);
-		*dma_mod = NULL;
-	}
-}
-
 int rsnd_dma_probe(struct rsnd_priv *priv)
 {
 	struct platform_device *pdev = rsnd_priv_to_pdev(priv);
diff --git a/sound/soc/sh/rcar/rsnd.h b/sound/soc/sh/rcar/rsnd.h
index 2460d1fbf775..c1cee1ab3e62 100644
--- a/sound/soc/sh/rcar/rsnd.h
+++ b/sound/soc/sh/rcar/rsnd.h
@@ -200,7 +200,6 @@ u32 rsnd_get_dalign(struct rsnd_mod *mod, struct rsnd_dai_stream *io);
  */
 int rsnd_dma_attach(struct rsnd_dai_stream *io,
 		    struct rsnd_mod *mod, struct rsnd_mod **dma_mod);
-void rsnd_dma_detach(struct rsnd_mod *mod, struct rsnd_mod **dma_mod);
 int rsnd_dma_probe(struct rsnd_priv *priv);
 struct dma_chan *rsnd_dma_request_channel(struct device_node *of_node,
 					  struct rsnd_mod *mod, char *name);
diff --git a/sound/soc/sh/rcar/ssi.c b/sound/soc/sh/rcar/ssi.c
index b0338d0a4cde..e23e07b54d8c 100644
--- a/sound/soc/sh/rcar/ssi.c
+++ b/sound/soc/sh/rcar/ssi.c
@@ -701,8 +701,6 @@ static int rsnd_ssi_dma_remove(struct rsnd_mod *mod,
 	/* PIO will request IRQ again */
 	free_irq(ssi->irq, mod);
 
-	rsnd_dma_detach(mod, &ssi->dma);
-
 	return 0;
 }
 
-- 
2.8.1

  reply	other threads:[~2016-10-25 19:23 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-25  0:35 [PATCH 0/8] ASoC: rsnd: DMA power fix and IOMMU support Kuninori Morimoto
2016-10-25  0:35 ` [PATCH 1/8] ASoC: rsnd: depends on OF Kuninori Morimoto
2016-10-25 13:28   ` Mark Brown
2016-10-26  0:00     ` Kuninori Morimoto
2016-10-26 15:12   ` Applied "ASoC: rsnd: depends on OF" to the asoc tree Mark Brown
2016-10-25  0:36 ` [PATCH 2/8] ASoC: rsnd: remove non DT support for DMA Kuninori Morimoto
2016-10-25 19:24   ` Applied "ASoC: rsnd: remove non DT support for DMA" to the asoc tree Mark Brown
2016-10-25  0:36 ` [PATCH 3/8] ASoC: rsnd: don't use devm_request_irq() for SSI Kuninori Morimoto
2016-10-25 19:23   ` Applied "ASoC: rsnd: don't use devm_request_irq() for SSI" to the asoc tree Mark Brown
2016-10-25  0:36 ` [PATCH 4/8] ASoC: rsnd: remove rsnd_dma_detach() Kuninori Morimoto
2016-10-25 19:23   ` Mark Brown [this message]
2016-10-25  0:37 ` [PATCH 5/8] ASoC: rsnd: don't call unneeded of_node_put() on dma.c Kuninori Morimoto
2016-10-25 19:23   ` Applied "ASoC: rsnd: don't call unneeded of_node_put() on dma.c" to the asoc tree Mark Brown
2016-10-25  0:37 ` [PATCH 6/8] ASoC: rsnd: add nolock_start/stop callback Kuninori Morimoto
2016-10-25 19:23   ` Applied "ASoC: rsnd: add nolock_start/stop callback" to the asoc tree Mark Brown
2016-10-25  0:37 ` [PATCH 7/8] ASoC: rsnd: Request/Release DMA channel each time Kuninori Morimoto
2016-10-25 14:02   ` Mark Brown
2016-10-25 23:55     ` Kuninori Morimoto
2016-10-25  0:38 ` [PATCH 8/8] ASoC: rsnd: use dma_sync_single_for_xxx() for IOMMU Kuninori Morimoto
2016-11-22 17:26   ` Applied "ASoC: rsnd: use dma_sync_single_for_xxx() for IOMMU" to the asoc tree Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1bz7K6-0004oK-Ka@debutante \
    --to=broonie@kernel.org \
    --cc=alsa-devel@alsa-project.org \
    --cc=horms@verge.net.au \
    --cc=kuninori.morimoto.gx@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox