[PATCH] ASoC: rt5670: Enable Braswell platform workaround for Dell Wyse 3040

[PATCH] ASoC: rt5670: Enable Braswell platform workaround for Dell Wyse 3040

[Takashi Iwai]

Dell Wyse 3040 requires the platform workaround for enabling dmic and
jack detection as defined for Braswell CRB.

Signed-off-by: Takashi Iwai <tiwai@suse.de>

---

I guess the platform data should be applied generically to all CHT
machines instead of DMI matching?  DMI matching doesn't scale,
obviously.

 sound/soc/codecs/rt5670.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/sound/soc/codecs/rt5670.c b/sound/soc/codecs/rt5670.c
index 98c7efbc6ee0..97bafac3bc15 100644
--- a/sound/soc/codecs/rt5670.c
+++ b/sound/soc/codecs/rt5670.c
@@ -2827,6 +2827,13 @@ static const struct dmi_system_id dmi_platform_intel_braswell[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "Braswell CRB"),
 		},
 	},
+	{
+		.ident = "Dell Wyse 3040",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Wyse 3040"),
+		},
+	},
 	{}
 };
 
-- 
2.10.2

Re: [PATCH] ASoC: rt5670: Enable Braswell platform workaround for Dell Wyse 3040

[Vinod Koul]

On Wed, Nov 30, 2016 at 05:19:20PM +0100, Takashi Iwai wrote:
> Dell Wyse 3040 requires the platform workaround for enabling dmic and
> jack detection as defined for Braswell CRB.
> 
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> 
> ---
> 
> I guess the platform data should be applied generically to all CHT
> machines instead of DMI matching?  DMI matching doesn't scale,
> obviously.

we ahve been doing this on other RT codecs like RT286/298 as well for combo
jack to work. Yeah a better solution would be welcomed :)

> 
>  sound/soc/codecs/rt5670.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/sound/soc/codecs/rt5670.c b/sound/soc/codecs/rt5670.c
> index 98c7efbc6ee0..97bafac3bc15 100644
> --- a/sound/soc/codecs/rt5670.c
> +++ b/sound/soc/codecs/rt5670.c
> @@ -2827,6 +2827,13 @@ static const struct dmi_system_id dmi_platform_intel_braswell[] = {
>  			DMI_MATCH(DMI_BOARD_NAME, "Braswell CRB"),
>  		},
>  	},
> +	{
> +		.ident = "Dell Wyse 3040",
> +		.matches = {
> +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> +			DMI_MATCH(DMI_PRODUCT_NAME, "Wyse 3040"),
> +		},
> +	},
>  	{}
>  };
>  
> -- 
> 2.10.2
> 

-- 
~Vinod

Re: [PATCH] ASoC: rt5670: Enable Braswell platform workaround for Dell Wyse 3040

[Takashi Iwai]

On Wed, 30 Nov 2016 17:36:15 +0100,
Vinod Koul wrote:
> 
> On Wed, Nov 30, 2016 at 05:19:20PM +0100, Takashi Iwai wrote:
> > Dell Wyse 3040 requires the platform workaround for enabling dmic and
> > jack detection as defined for Braswell CRB.
> > 
> > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > 
> > ---
> > 
> > I guess the platform data should be applied generically to all CHT
> > machines instead of DMI matching?  DMI matching doesn't scale,
> > obviously.
> 
> we ahve been doing this on other RT codecs like RT286/298 as well for combo
> jack to work. Yeah a better solution would be welcomed :)

Well, the question is how generic the given platform-specific setup
is.  I guess we can keep the dmi thingy for a while, although we'll
need more generic solution (or a pattern matching for a wider range of
machines).  So, if you think the addition of DMI entries is OK, give
your ack :)


thanks,

Takashi


> 
> > 
> >  sound/soc/codecs/rt5670.c | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/sound/soc/codecs/rt5670.c b/sound/soc/codecs/rt5670.c
> > index 98c7efbc6ee0..97bafac3bc15 100644
> > --- a/sound/soc/codecs/rt5670.c
> > +++ b/sound/soc/codecs/rt5670.c
> > @@ -2827,6 +2827,13 @@ static const struct dmi_system_id dmi_platform_intel_braswell[] = {
> >  			DMI_MATCH(DMI_BOARD_NAME, "Braswell CRB"),
> >  		},
> >  	},
> > +	{
> > +		.ident = "Dell Wyse 3040",
> > +		.matches = {
> > +			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
> > +			DMI_MATCH(DMI_PRODUCT_NAME, "Wyse 3040"),
> > +		},
> > +	},
> >  	{}
> >  };
> >  
> > -- 
> > 2.10.2
> > 
> 
> -- 
> ~Vinod
> 

Re: [PATCH] ASoC: rt5670: Enable Braswell platform workaround for Dell Wyse 3040

[Vinod Koul]

On Wed, Nov 30, 2016 at 05:30:25PM +0100, Takashi Iwai wrote:
> On Wed, 30 Nov 2016 17:36:15 +0100,
> Vinod Koul wrote:
> > 
> > On Wed, Nov 30, 2016 at 05:19:20PM +0100, Takashi Iwai wrote:
> > > Dell Wyse 3040 requires the platform workaround for enabling dmic and
> > > jack detection as defined for Braswell CRB.
> > > 
> > > Signed-off-by: Takashi Iwai <tiwai@suse.de>
> > > 
> > > ---
> > > 
> > > I guess the platform data should be applied generically to all CHT
> > > machines instead of DMI matching?  DMI matching doesn't scale,
> > > obviously.
> > 
> > we ahve been doing this on other RT codecs like RT286/298 as well for combo
> > jack to work. Yeah a better solution would be welcomed :)
> 
> Well, the question is how generic the given platform-specific setup
> is.  I guess we can keep the dmi thingy for a while, although we'll
> need more generic solution (or a pattern matching for a wider range of
> machines). 

Mostly if people stuck to Intel ref designs, then it would same, which has
been a problem on embedded side, but who knows.. :(

> So, if you think the addition of DMI entries is OK, give
> your ack :)

Absolutely atm :)

Acked-by: Vinod Koul <vinod.koul@intel.com>

-- 
~Vinod

Re: [PATCH] ASoC: rt5670: Enable Braswell platform workaround for Dell Wyse 3040

[Mark Brown]

[-- Attachment #1.1: Type: text/plain, Size: 830 bytes --]

On Thu, Dec 01, 2016 at 09:00:58AM +0530, Vinod Koul wrote:
> On Wed, Nov 30, 2016 at 05:30:25PM +0100, Takashi Iwai wrote:

> > Well, the question is how generic the given platform-specific setup
> > is.  I guess we can keep the dmi thingy for a while, although we'll
> > need more generic solution (or a pattern matching for a wider range of
> > machines). 

> Mostly if people stuck to Intel ref designs, then it would same, which has
> been a problem on embedded side, but who knows.. :(

That's just not at all realistic - if the systems are only going to be
supportable when people copy the reference designs verbatim then we're
going to have serious problems, that's just not how things work in the
real world (especially at the higher end of the market where there's a
greater desire for differentiation).

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

[-- Attachment #2: Type: text/plain, Size: 0 bytes --]

Applied "ASoC: rt5670: Enable Braswell platform workaround for Dell Wyse 3040" to the asoc tree

[Mark Brown]

The patch

   ASoC: rt5670: Enable Braswell platform workaround for Dell Wyse 3040

has been applied to the asoc tree at

   git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git 

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.  

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

>From b4ff47d2843f7df61b956c8ee4a576bf83b11fab Mon Sep 17 00:00:00 2001
From: Takashi Iwai <tiwai@suse.de>
Date: Wed, 30 Nov 2016 17:19:20 +0100
Subject: [PATCH] ASoC: rt5670: Enable Braswell platform workaround for Dell
 Wyse 3040

Dell Wyse 3040 requires the platform workaround for enabling dmic and
jack detection as defined for Braswell CRB.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
 sound/soc/codecs/rt5670.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/sound/soc/codecs/rt5670.c b/sound/soc/codecs/rt5670.c
index 12d3bc14a558..d32ebe73c2c9 100644
--- a/sound/soc/codecs/rt5670.c
+++ b/sound/soc/codecs/rt5670.c
@@ -2826,6 +2826,13 @@ static const struct dmi_system_id dmi_platform_intel_braswell[] = {
 			DMI_MATCH(DMI_BOARD_NAME, "Braswell CRB"),
 		},
 	},
+	{
+		.ident = "Dell Wyse 3040",
+		.matches = {
+			DMI_MATCH(DMI_SYS_VENDOR, "Dell Inc."),
+			DMI_MATCH(DMI_PRODUCT_NAME, "Wyse 3040"),
+		},
+	},
 	{}
 };
 
-- 
2.10.2