* Re: [PATCH] dt-bindings: ASoC: rsnd: Add device tree support for r8a774[35]
2017-12-12 18:09 [PATCH] dt-bindings: ASoC: rsnd: Add device tree support for r8a774[35] Biju Das
@ 2017-12-13 10:16 ` Geert Uytterhoeven
2017-12-13 12:20 ` Mark Brown
` (2 subsequent siblings)
3 siblings, 0 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2017-12-13 10:16 UTC (permalink / raw)
To: Biju Das
Cc: Liam Girdwood, Mark Brown, Rob Herring, Mark Rutland,
Simon Horman, Magnus Damm, Chris Paterson, Fabrizio Castro,
ALSA Development Mailing List, Linux-Renesas
On Tue, Dec 12, 2017 at 7:09 PM, Biju Das <biju.das@bp.renesas.com> wrote:
> Document r8a774[35] specific compatible strings. The Renesas RZ/G1[ME]
> (r8a774[35]) sound modules are identical to the R-Car Gen2 family.
> No driver change is needed as the fallback compatible string
> "renesas,rcar_sound-gen2" activates the right code in the driver.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] dt-bindings: ASoC: rsnd: Add device tree support for r8a774[35]
2017-12-12 18:09 [PATCH] dt-bindings: ASoC: rsnd: Add device tree support for r8a774[35] Biju Das
2017-12-13 10:16 ` Geert Uytterhoeven
@ 2017-12-13 12:20 ` Mark Brown
2017-12-13 12:34 ` Geert Uytterhoeven
2017-12-13 13:35 ` [PATCH v2] " Biju Das
2017-12-13 15:46 ` Applied "ASoC: rsnd: Add device tree support for r8a774[35]" to the asoc tree Mark Brown
3 siblings, 1 reply; 9+ messages in thread
From: Mark Brown @ 2017-12-13 12:20 UTC (permalink / raw)
To: Biju Das
Cc: Liam Girdwood, Rob Herring, Mark Rutland, Simon Horman,
Magnus Damm, Chris Paterson, Fabrizio Castro, alsa-devel,
linux-renesas-soc
[-- Attachment #1: Type: text/plain, Size: 617 bytes --]
On Tue, Dec 12, 2017 at 06:09:15PM +0000, Biju Das wrote:
> Document r8a774[35] specific compatible strings. The Renesas RZ/G1[ME]
> (r8a774[35]) sound modules are identical to the R-Car Gen2 family.
> No driver change is needed as the fallback compatible string
> "renesas,rcar_sound-gen2" activates the right code in the driver.
Please submit patches using subject lines reflecting the style for the
subsystem. This makes it easier for people to identify relevant
patches. Look at what existing commits in the area you're changing are
doing and make sure your subject lines visually resemble what they're
doing.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] dt-bindings: ASoC: rsnd: Add device tree support for r8a774[35]
2017-12-13 12:20 ` Mark Brown
@ 2017-12-13 12:34 ` Geert Uytterhoeven
2017-12-13 12:55 ` Mark Brown
0 siblings, 1 reply; 9+ messages in thread
From: Geert Uytterhoeven @ 2017-12-13 12:34 UTC (permalink / raw)
To: Mark Brown
Cc: Biju Das, Liam Girdwood, Rob Herring, Mark Rutland, Simon Horman,
Magnus Damm, Chris Paterson, Fabrizio Castro,
ALSA Development Mailing List, Linux-Renesas
Hi Mark,
On Wed, Dec 13, 2017 at 1:20 PM, Mark Brown <broonie@kernel.org> wrote:
> On Tue, Dec 12, 2017 at 06:09:15PM +0000, Biju Das wrote:
>> Document r8a774[35] specific compatible strings. The Renesas RZ/G1[ME]
>> (r8a774[35]) sound modules are identical to the R-Car Gen2 family.
>> No driver change is needed as the fallback compatible string
>> "renesas,rcar_sound-gen2" activates the right code in the driver.
>
> Please submit patches using subject lines reflecting the style for the
> subsystem. This makes it easier for people to identify relevant
> patches. Look at what existing commits in the area you're changing are
> doing and make sure your subject lines visually resemble what they're
> doing.
The confusing part here is that for most[*] subsystems, patches touching
only DT bindings should have a "dt-bindings" prefix, while patches touching
both DT bindings and driver code should have the drivers' subsystem prefix.
[*] I think you're about the only maintainer who insists on patches touching
only DT bindings having the drivers' subsystem prefix, which people tend to
forget, if they're even aware of that rule...
Can we improve this?
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] dt-bindings: ASoC: rsnd: Add device tree support for r8a774[35]
2017-12-13 12:34 ` Geert Uytterhoeven
@ 2017-12-13 12:55 ` Mark Brown
2017-12-13 13:14 ` Biju Das
0 siblings, 1 reply; 9+ messages in thread
From: Mark Brown @ 2017-12-13 12:55 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Biju Das, Liam Girdwood, Rob Herring, Mark Rutland, Simon Horman,
Magnus Damm, Chris Paterson, Fabrizio Castro,
ALSA Development Mailing List, Linux-Renesas
[-- Attachment #1: Type: text/plain, Size: 900 bytes --]
On Wed, Dec 13, 2017 at 01:34:40PM +0100, Geert Uytterhoeven wrote:
> The confusing part here is that for most[*] subsystems, patches touching
> only DT bindings should have a "dt-bindings" prefix, while patches touching
> both DT bindings and driver code should have the drivers' subsystem prefix.
> [*] I think you're about the only maintainer who insists on patches touching
> only DT bindings having the drivers' subsystem prefix, which people tend to
> forget, if they're even aware of that rule...
> Can we improve this?
This is something Rob's been pushing which seems like a step back to me
so I've been pushing back on it - it's causing problems for me spotting
things I need to look at and later on in review (including my scripting,
which does pay attention to subject lines). I suspect I'm at the upper
end of people getting lots of irrelevant stuff in copy which doesn't
help here.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 484 bytes --]
^ permalink raw reply [flat|nested] 9+ messages in thread
* RE: [PATCH] dt-bindings: ASoC: rsnd: Add device tree support for r8a774[35]
2017-12-13 12:55 ` Mark Brown
@ 2017-12-13 13:14 ` Biju Das
0 siblings, 0 replies; 9+ messages in thread
From: Biju Das @ 2017-12-13 13:14 UTC (permalink / raw)
To: Mark Brown, Geert Uytterhoeven
Cc: Liam Girdwood, Rob Herring, Mark Rutland, Simon Horman,
Magnus Damm, Chris Paterson, Fabrizio Castro,
ALSA Development Mailing List, Linux-Renesas
Hi all,
Thanks for the feedback, I will send a v2.
Regards,
Biju
> -----Original Message-----
> From: Mark Brown [mailto:broonie@kernel.org]
> Sent: 13 December 2017 12:56
> To: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Biju Das <biju.das@bp.renesas.com>; Liam Girdwood
> <lgirdwood@gmail.com>; Rob Herring <robh+dt@kernel.org>; Mark Rutland
> <mark.rutland@arm.com>; Simon Horman <horms@verge.net.au>; Magnus
> Damm <magnus.damm@gmail.com>; Chris Paterson
> <Chris.Paterson2@renesas.com>; Fabrizio Castro
> <fabrizio.castro@bp.renesas.com>; ALSA Development Mailing List <alsa-
> devel@alsa-project.org>; Linux-Renesas <linux-renesas-soc@vger.kernel.org>
> Subject: Re: [PATCH] dt-bindings: ASoC: rsnd: Add device tree support for
> r8a774[35]
>
> On Wed, Dec 13, 2017 at 01:34:40PM +0100, Geert Uytterhoeven wrote:
>
> > The confusing part here is that for most[*] subsystems, patches
> > touching only DT bindings should have a "dt-bindings" prefix, while
> > patches touching both DT bindings and driver code should have the drivers'
> subsystem prefix.
>
> > [*] I think you're about the only maintainer who insists on patches
> > touching only DT bindings having the drivers' subsystem prefix, which
> > people tend to forget, if they're even aware of that rule...
>
> > Can we improve this?
>
> This is something Rob's been pushing which seems like a step back to me so I've
> been pushing back on it - it's causing problems for me spotting things I need to
> look at and later on in review (including my scripting, which does pay attention
> to subject lines). I suspect I'm at the upper end of people getting lots of
> irrelevant stuff in copy which doesn't help here.
[https://www2.renesas.eu/media/email/unicef_2017.jpg]
This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world.
We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year.
Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH v2] ASoC: rsnd: Add device tree support for r8a774[35]
2017-12-12 18:09 [PATCH] dt-bindings: ASoC: rsnd: Add device tree support for r8a774[35] Biju Das
2017-12-13 10:16 ` Geert Uytterhoeven
2017-12-13 12:20 ` Mark Brown
@ 2017-12-13 13:35 ` Biju Das
2017-12-13 13:45 ` Geert Uytterhoeven
2017-12-13 15:46 ` Applied "ASoC: rsnd: Add device tree support for r8a774[35]" to the asoc tree Mark Brown
3 siblings, 1 reply; 9+ messages in thread
From: Biju Das @ 2017-12-13 13:35 UTC (permalink / raw)
To: Liam Girdwood, Mark Brown, Rob Herring, Mark Rutland
Cc: Simon Horman, Magnus Damm, Chris Paterson, Fabrizio Castro,
alsa-devel, linux-renesas-soc, Biju Das
Document r8a774[35] specific compatible strings. The Renesas RZ/G1[ME]
(r8a774[35]) sound modules are identical to the R-Car Gen2 family.
No driver change is needed as the fallback compatible string
"renesas,rcar_sound-gen2" activates the right code in the driver.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
v1-->v2
Updated the subject line.
Documentation/devicetree/bindings/sound/renesas,rsnd.txt | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.txt b/Documentation/devicetree/bindings/sound/renesas,rsnd.txt
index 085bec3..b3c28bd 100644
--- a/Documentation/devicetree/bindings/sound/renesas,rsnd.txt
+++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.txt
@@ -4,7 +4,7 @@ Renesas R-Car sound
* Modules
=============================================
-Renesas R-Car sound is constructed from below modules
+Renesas R-Car and RZ/G sound is constructed from below modules
(for Gen2 or later)
SCU : Sampling Rate Converter Unit
@@ -334,9 +334,11 @@ Required properties:
- compatible : "renesas,rcar_sound-<soctype>", fallbacks
"renesas,rcar_sound-gen1" if generation1, and
- "renesas,rcar_sound-gen2" if generation2
+ "renesas,rcar_sound-gen2" if generation2 (or RZ/G1)
"renesas,rcar_sound-gen3" if generation3
Examples with soctypes are:
+ - "renesas,rcar_sound-r8a7743" (RZ/G1M)
+ - "renesas,rcar_sound-r8a7745" (RZ/G1E)
- "renesas,rcar_sound-r8a7778" (R-Car M1A)
- "renesas,rcar_sound-r8a7779" (R-Car H1)
- "renesas,rcar_sound-r8a7790" (R-Car H2)
--
1.9.1
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH v2] ASoC: rsnd: Add device tree support for r8a774[35]
2017-12-13 13:35 ` [PATCH v2] " Biju Das
@ 2017-12-13 13:45 ` Geert Uytterhoeven
0 siblings, 0 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2017-12-13 13:45 UTC (permalink / raw)
To: Biju Das
Cc: Liam Girdwood, Mark Brown, Rob Herring, Mark Rutland,
Simon Horman, Magnus Damm, Chris Paterson, Fabrizio Castro,
ALSA Development Mailing List, Linux-Renesas
On Wed, Dec 13, 2017 at 2:35 PM, Biju Das <biju.das@bp.renesas.com> wrote:
> Document r8a774[35] specific compatible strings. The Renesas RZ/G1[ME]
> (r8a774[35]) sound modules are identical to the R-Car Gen2 family.
> No driver change is needed as the fallback compatible string
> "renesas,rcar_sound-gen2" activates the right code in the driver.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>
> Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 9+ messages in thread
* Applied "ASoC: rsnd: Add device tree support for r8a774[35]" to the asoc tree
2017-12-12 18:09 [PATCH] dt-bindings: ASoC: rsnd: Add device tree support for r8a774[35] Biju Das
` (2 preceding siblings ...)
2017-12-13 13:35 ` [PATCH v2] " Biju Das
@ 2017-12-13 15:46 ` Mark Brown
3 siblings, 0 replies; 9+ messages in thread
From: Mark Brown @ 2017-12-13 15:46 UTC (permalink / raw)
To: Biju Das; +Cc: Mark Brown, Liam Girdwood
The patch
ASoC: rsnd: Add device tree support for r8a774[35]
has been applied to the asoc tree at
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git
All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying
to this mail.
Thanks,
Mark
>From b0a858a47a7889757dbc9ac9872685955eaa5cc0 Mon Sep 17 00:00:00 2001
From: Biju Das <biju.das@bp.renesas.com>
Date: Tue, 12 Dec 2017 18:09:15 +0000
Subject: [PATCH] ASoC: rsnd: Add device tree support for r8a774[35]
Document r8a774[35] specific compatible strings. The Renesas RZ/G1[ME]
(r8a774[35]) sound modules are identical to the R-Car Gen2 family.
No driver change is needed as the fallback compatible string
"renesas,rcar_sound-gen2" activates the right code in the driver.
Signed-off-by: Biju Das <biju.das@bp.renesas.com>
Reviewed-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Signed-off-by: Mark Brown <broonie@kernel.org>
---
Documentation/devicetree/bindings/sound/renesas,rsnd.txt | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.txt b/Documentation/devicetree/bindings/sound/renesas,rsnd.txt
index 085bec364caf..b3c28bdcc268 100644
--- a/Documentation/devicetree/bindings/sound/renesas,rsnd.txt
+++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.txt
@@ -4,7 +4,7 @@ Renesas R-Car sound
* Modules
=============================================
-Renesas R-Car sound is constructed from below modules
+Renesas R-Car and RZ/G sound is constructed from below modules
(for Gen2 or later)
SCU : Sampling Rate Converter Unit
@@ -334,9 +334,11 @@ Required properties:
- compatible : "renesas,rcar_sound-<soctype>", fallbacks
"renesas,rcar_sound-gen1" if generation1, and
- "renesas,rcar_sound-gen2" if generation2
+ "renesas,rcar_sound-gen2" if generation2 (or RZ/G1)
"renesas,rcar_sound-gen3" if generation3
Examples with soctypes are:
+ - "renesas,rcar_sound-r8a7743" (RZ/G1M)
+ - "renesas,rcar_sound-r8a7745" (RZ/G1E)
- "renesas,rcar_sound-r8a7778" (R-Car M1A)
- "renesas,rcar_sound-r8a7779" (R-Car H1)
- "renesas,rcar_sound-r8a7790" (R-Car H2)
--
2.15.1
^ permalink raw reply related [flat|nested] 9+ messages in thread
