Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: alsa-devel@alsa-project.org
Cc: Dan Carpenter <dan.carpenter@oracle.com>
Subject: [PATCH 0/8] ALSA: Hardening for potential Spectre v1
Date: Tue, 24 Apr 2018 09:56:11 +0200	[thread overview]
Message-ID: <20180424075619.29602-1-tiwai@suse.de> (raw)

Hi,

this is a patchset to cover the potential issues wrt Spectre v1 that
were spotted out recently by Smatch:
  https://marc.info/?l=linux-kernel&m=152411496503418&w=2

Although all reports for sound/* seem like no serious issues, it's
better to cover potential usages than a too late sorry.

The first patch is basically irrelevant for Spectre but a preliminary
fix for the following fix.  Most of the rest patches are
straightforward, but the second one, the fix for OSS emulation, became
a fair amount of code refactoring in the end.

An open question is whether we should put Cc-to-stable to these
fixes.  Maybe yes, although we've never proven that the problem would
actually exist, the issue is still "hot", so people may want to see
them more-or-less covered...


thanks,

Takashi

===

Takashi Iwai (8):
  ALSA: seq: oss: Fix unbalanced use lock for synth MIDI device
  ALSA: seq: oss: Hardening for potential Spectre v1
  ALSA: control: Hardening for potential Spectre v1
  ALSA: hda: Hardening for potential Spectre v1
  ALSA: opl3: Hardening for potential Spectre v1
  ALSA: asihpi: Hardening for potential Spectre v1
  ALSA: hdspm: Hardening for potential Spectre v1
  ALSA: rme9652: Hardening for potential Spectre v1

 include/sound/control.h            |  7 +++-
 sound/core/seq/oss/seq_oss_event.c | 15 ++++---
 sound/core/seq/oss/seq_oss_midi.c  |  2 +
 sound/core/seq/oss/seq_oss_synth.c | 85 ++++++++++++++++++++++----------------
 sound/core/seq/oss/seq_oss_synth.h |  3 +-
 sound/drivers/opl3/opl3_synth.c    |  7 +++-
 sound/pci/asihpi/hpimsginit.c      | 13 ++++--
 sound/pci/asihpi/hpioctl.c         |  4 +-
 sound/pci/hda/hda_hwdep.c          | 12 +++++-
 sound/pci/rme9652/hdspm.c          | 24 ++++++-----
 sound/pci/rme9652/rme9652.c        |  6 ++-
 11 files changed, 113 insertions(+), 65 deletions(-)

-- 
2.16.3

             reply	other threads:[~2018-04-24  7:56 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24  7:56 Takashi Iwai [this message]
2018-04-24  7:56 ` [PATCH 1/8] ALSA: seq: oss: Fix unbalanced use lock for synth MIDI device Takashi Iwai
2018-04-24  7:56 ` [PATCH 2/8] ALSA: seq: oss: Hardening for potential Spectre v1 Takashi Iwai
2018-04-24  7:56 ` [PATCH 3/8] ALSA: control: " Takashi Iwai
2018-04-24  7:56 ` [PATCH 4/8] ALSA: hda: " Takashi Iwai
2018-04-24  7:56 ` [PATCH 5/8] ALSA: opl3: " Takashi Iwai
2018-04-24  7:56 ` [PATCH 6/8] ALSA: asihpi: " Takashi Iwai
2018-04-24  7:56 ` [PATCH 7/8] ALSA: hdspm: " Takashi Iwai
2018-04-24  7:56 ` [PATCH 8/8] ALSA: rme9652: " Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180424075619.29602-1-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=dan.carpenter@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox