From: Mark Brown <broonie@kernel.org>
To: Puneeth Prabhu <puneethx.prabhu@intel.com>
Cc: ALSA ML <alsa-devel@alsa-project.org>,
Takashi Iwai <tiwai@suse.de>,
pardha.saradhi.kesapragada@intel.com, cezary.rojewski@intel.com,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Patches Audio <patches.audio@intel.com>,
gustaw.lewandowski@intel.com
Subject: Re: [PATCH] topology: ABI: Increase SND_SOC_TPLG_NUM_TEXTS to 32
Date: Fri, 20 Jul 2018 13:39:49 +0100 [thread overview]
Message-ID: <20180720123949.GH10784@sirena.org.uk> (raw)
In-Reply-To: <1532082427-4912-2-git-send-email-puneethx.prabhu@intel.com>
[-- Attachment #1.1: Type: text/plain, Size: 687 bytes --]
On Fri, Jul 20, 2018 at 03:57:07PM +0530, Puneeth Prabhu wrote:
> index bb8aec7..eb61483 100644
> --- a/include/sound/asoc.h
> +++ b/include/sound/asoc.h
> @@ -84,7 +84,7 @@
> #define SND_SOC_TPLG_MAGIC 0x41536F43 /* ASoC */
>
> /* string sizes */
> -#define SND_SOC_TPLG_NUM_TEXTS 16
> +#define SND_SOC_TPLG_NUM_TEXTS 32
>
> /* ABI version */
> #define SND_SOC_TPLG_ABI_VERSION 0x5 /* current version */
Hrm, we should be getting rid of the duplication here - include the UAPI
header in sound/asoc.h rather than duplicating definitions between the
two. Otherwise someone might modify something in sound/asoc.h and not
realize that the UAPI is affected.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 0 bytes --]
next prev parent reply other threads:[~2018-07-20 12:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 10:27 [PATCH] ASoC: topology: Increase SND_SOC_TPLG_NUM_TEXTS to 32 Puneeth Prabhu
2018-07-20 10:27 ` [PATCH] topology: ABI: " Puneeth Prabhu
2018-07-20 12:39 ` Mark Brown [this message]
2018-07-20 12:38 ` [PATCH] ASoC: topology: " Mark Brown
2018-07-20 13:58 ` Pierre-Louis Bossart
2018-07-20 14:46 ` Mark Brown
2018-07-20 16:02 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180720123949.GH10784@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=cezary.rojewski@intel.com \
--cc=gustaw.lewandowski@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=pardha.saradhi.kesapragada@intel.com \
--cc=patches.audio@intel.com \
--cc=puneethx.prabhu@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox