From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Mark Brown <broonie@kernel.org>,
Puneeth Prabhu <puneethx.prabhu@intel.com>
Cc: ALSA ML <alsa-devel@alsa-project.org>,
Takashi Iwai <tiwai@suse.de>,
pardha.saradhi.kesapragada@intel.com, cezary.rojewski@intel.com,
Liam Girdwood <liam.r.girdwood@linux.intel.com>,
Patches Audio <patches.audio@intel.com>,
gustaw.lewandowski@intel.com
Subject: Re: [PATCH] ASoC: topology: Increase SND_SOC_TPLG_NUM_TEXTS to 32
Date: Fri, 20 Jul 2018 08:58:07 -0500 [thread overview]
Message-ID: <cc342153-28fd-85bf-acab-a695882af115@linux.intel.com> (raw)
In-Reply-To: <20180720123820.GG10784@sirena.org.uk>
On 7/20/18 7:38 AM, Mark Brown wrote:
> On Fri, Jul 20, 2018 at 03:57:06PM +0530, Puneeth Prabhu wrote:
>
>> /* string sizes */
>> -#define SND_SOC_TPLG_NUM_TEXTS 16
>> +#define SND_SOC_TPLG_NUM_TEXTS 32
>
> This will increase the size of the texts and values fields of at least
> snd_soc_tplg_enum_control which on the face of it appears to be an
> incompatible ABI change, topology files created with the old value will
> have a different layout for these structures to those created with the
> new one.
Agree with Mark on both points (de-duplication needed and backwards
compatibility). If we are going to respin a new version, there are a
couple of known limitations we may want to fix as well, such as the
limitation to 8 channels and others I will remember once I've had more
coffee.
next prev parent reply other threads:[~2018-07-20 13:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-20 10:27 [PATCH] ASoC: topology: Increase SND_SOC_TPLG_NUM_TEXTS to 32 Puneeth Prabhu
2018-07-20 10:27 ` [PATCH] topology: ABI: " Puneeth Prabhu
2018-07-20 12:39 ` Mark Brown
2018-07-20 12:38 ` [PATCH] ASoC: topology: " Mark Brown
2018-07-20 13:58 ` Pierre-Louis Bossart [this message]
2018-07-20 14:46 ` Mark Brown
2018-07-20 16:02 ` Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cc342153-28fd-85bf-acab-a695882af115@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=gustaw.lewandowski@intel.com \
--cc=liam.r.girdwood@linux.intel.com \
--cc=pardha.saradhi.kesapragada@intel.com \
--cc=patches.audio@intel.com \
--cc=puneethx.prabhu@intel.com \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox