* [PATCH] soundwire: intel: Fix uninitialized adev deref
@ 2018-08-07 6:41 Vinod Koul
2018-08-07 14:22 ` Pierre-Louis Bossart
0 siblings, 1 reply; 2+ messages in thread
From: Vinod Koul @ 2018-08-07 6:41 UTC (permalink / raw)
To: alsa-devel
Cc: Vinod Koul, Sanyog Kale, Pierre-Louis Bossart, dan.carpenter,
Shreyas NC
In case of error, we can dereference uninitialized 'adev'
drivers/soundwire/intel_init.c:154 sdw_intel_acpi_cb()
error: uninitialized symbol 'adev'.
Fix that by not using adev for warn print and make it pr_err.
Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
---
drivers/soundwire/intel_init.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soundwire/intel_init.c b/drivers/soundwire/intel_init.c
index d1ea6b4d0ad3..5c8a20d99878 100644
--- a/drivers/soundwire/intel_init.c
+++ b/drivers/soundwire/intel_init.c
@@ -151,7 +151,7 @@ static acpi_status sdw_intel_acpi_cb(acpi_handle handle, u32 level,
struct acpi_device *adev;
if (acpi_bus_get_device(handle, &adev)) {
- dev_err(&adev->dev, "Couldn't find ACPI handle\n");
+ pr_err("%s: Couldn't find ACPI handle\n", __func__);
return AE_NOT_FOUND;
}
--
2.14.4
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] soundwire: intel: Fix uninitialized adev deref
2018-08-07 6:41 [PATCH] soundwire: intel: Fix uninitialized adev deref Vinod Koul
@ 2018-08-07 14:22 ` Pierre-Louis Bossart
0 siblings, 0 replies; 2+ messages in thread
From: Pierre-Louis Bossart @ 2018-08-07 14:22 UTC (permalink / raw)
To: Vinod Koul, alsa-devel; +Cc: Sanyog Kale, dan.carpenter, Shreyas NC
On 8/7/18 1:41 AM, Vinod Koul wrote:
> In case of error, we can dereference uninitialized 'adev'
>
> drivers/soundwire/intel_init.c:154 sdw_intel_acpi_cb()
> error: uninitialized symbol 'adev'.
>
> Fix that by not using adev for warn print and make it pr_err.
>
> Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
> Signed-off-by: Vinod Koul <vkoul@kernel.org>
Acked-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
> ---
> drivers/soundwire/intel_init.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/soundwire/intel_init.c b/drivers/soundwire/intel_init.c
> index d1ea6b4d0ad3..5c8a20d99878 100644
> --- a/drivers/soundwire/intel_init.c
> +++ b/drivers/soundwire/intel_init.c
> @@ -151,7 +151,7 @@ static acpi_status sdw_intel_acpi_cb(acpi_handle handle, u32 level,
> struct acpi_device *adev;
>
> if (acpi_bus_get_device(handle, &adev)) {
> - dev_err(&adev->dev, "Couldn't find ACPI handle\n");
> + pr_err("%s: Couldn't find ACPI handle\n", __func__);
> return AE_NOT_FOUND;
> }
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-07 14:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-08-07 6:41 [PATCH] soundwire: intel: Fix uninitialized adev deref Vinod Koul
2018-08-07 14:22 ` Pierre-Louis Bossart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox