From: Mark Brown <broonie@kernel.org>
To: "Michał Mirosław" <mirq-linux@rere.qmqm.pl>
Cc: alsa-devel@alsa-project.org,
Alexandre Belloni <alexandre.belloni@bootlin.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
Ludovic Desroches <ludovic.desroches@microchip.com>,
Codrin Ciubotariu <codrin.ciubotariu@microchip.com>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/5] ASoC: atmel: enable SSC_PCM_DMA in Kconfig
Date: Tue, 23 Jul 2019 18:18:17 +0100 [thread overview]
Message-ID: <20190723171817.GP5365@sirena.org.uk> (raw)
In-Reply-To: <ee65cc7b889b2a8d1139d1d25977842c956d1cf4.1563819483.git.mirq-linux@rere.qmqm.pl>
[-- Attachment #1.1: Type: text/plain, Size: 700 bytes --]
On Mon, Jul 22, 2019 at 08:27:20PM +0200, Michał Mirosław wrote:
> config SND_ATMEL_SOC_SSC_DMA
> - tristate
> + tristate "SoC PCM DAI support for AT91 SSC controller using DMA"
This breaks the build for me:
ld: sound/soc/atmel/atmel_ssc_dai.o: in function `atmel_ssc_set_audio':
atmel_ssc_dai.c:(.text+0xbd9): undefined reference to `ssc_request'
ld: sound/soc/atmel/atmel_ssc_dai.o: in function `atmel_ssc_put_audio':
atmel_ssc_dai.c:(.text+0xc74): undefined reference to `ssc_free'
It's not selecting the SSC comon code. It also looks like it'd be
sensible to add a dependency on the platform (or at least architecture),
with a || COMPILE_TEST to help with build coverage.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-07-23 17:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-22 18:27 [PATCH 0/5] ASoC: atmel: extend SSC support Michał Mirosław
2019-07-22 18:27 ` [PATCH 1/5] ASoC: atmel: enable SSC_PCM_DMA in Kconfig Michał Mirosław
2019-07-23 13:36 ` Codrin.Ciubotariu
2019-07-23 16:43 ` mirq-linux
2019-07-23 17:27 ` Codrin.Ciubotariu
2019-07-23 18:39 ` Alexandre Belloni
2019-07-23 23:25 ` mirq-linux
2019-07-25 15:25 ` Codrin.Ciubotariu
2019-08-23 15:09 ` Alexandre Belloni
2019-07-23 17:18 ` Mark Brown [this message]
2019-07-22 18:27 ` [PATCH 5/5] ASoC: atmel_ssc_dai: Enable shared FSYNC source in frame-slave mode Michał Mirosław
2019-07-25 15:02 ` Codrin.Ciubotariu
2019-07-25 18:24 ` mirq-linux
2019-07-26 10:33 ` Codrin.Ciubotariu
2019-07-26 12:08 ` mirq-linux
2019-07-22 18:27 ` [PATCH 4/5] ASoC: atmel_ssc_dai: split TX/RX FS constants Michał Mirosław
2019-07-25 13:28 ` Codrin.Ciubotariu
2019-07-22 18:27 ` [PATCH 3/5] ASoC: atmel_ssc_dai: implement left-justified data mode Michał Mirosław
2019-07-25 13:15 ` Codrin.Ciubotariu
2019-07-22 18:27 ` [PATCH 2/5] ASoC: atmel_ssc_dai: rework DAI format configuration Michał Mirosław
2019-07-24 10:35 ` Codrin.Ciubotariu
2019-07-24 11:15 ` mirq-linux
2019-07-24 12:54 ` Codrin.Ciubotariu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190723171817.GP5365@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alexandre.belloni@bootlin.com \
--cc=alsa-devel@alsa-project.org \
--cc=codrin.ciubotariu@microchip.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=ludovic.desroches@microchip.com \
--cc=mirq-linux@rere.qmqm.pl \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox