Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: <Codrin.Ciubotariu@microchip.com>
To: mirq-linux@rere.qmqm.pl, alsa-devel@alsa-project.org
Cc: alexandre.belloni@bootlin.com, lgirdwood@gmail.com,
	tiwai@suse.com, Ludovic.Desroches@microchip.com,
	broonie@kernel.org, perex@perex.cz,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 4/5] ASoC: atmel_ssc_dai: split TX/RX FS constants
Date: Thu, 25 Jul 2019 13:28:38 +0000	[thread overview]
Message-ID: <57d6fb37-7472-e6fc-8cb7-9832ab78a171@microchip.com> (raw)
In-Reply-To: <718983d82091da8cf619010c026dca541af3f4d1.1563819483.git.mirq-linux@rere.qmqm.pl>

On 22.07.2019 21:27, Michał Mirosław wrote:
> External E-Mail
> 
> 
> The constants are the same, but the names are misleading when used for
> TCMR configuration. Use names from SAMA5D2 datasheet.
> 
> Signed-off-by: Michał Mirosław <mirq-linux@rere.qmqm.pl>
> ---
>   sound/soc/atmel/atmel_ssc_dai.c | 6 +++---
>   sound/soc/atmel/atmel_ssc_dai.h | 9 ++++++++-
>   2 files changed, 11 insertions(+), 4 deletions(-)
> 
> diff --git a/sound/soc/atmel/atmel_ssc_dai.c b/sound/soc/atmel/atmel_ssc_dai.c
> index 04541d7c33fe..cf2cfc345676 100644
> --- a/sound/soc/atmel/atmel_ssc_dai.c
> +++ b/sound/soc/atmel/atmel_ssc_dai.c
> @@ -572,7 +572,7 @@ static int atmel_ssc_hw_params(struct snd_pcm_substream *substream,
>   			| SSC_BF(RCMR_START, SSC_START_RISING_RF);
>   
>   		tcmr =	  SSC_BF(TCMR_STTDLY, 0)
> -			| SSC_BF(TCMR_START, SSC_START_RISING_RF);
> +			| SSC_BF(TCMR_START, SSC_START_RISING_TF);
>   
>   		break;
>   
> @@ -584,7 +584,7 @@ static int atmel_ssc_hw_params(struct snd_pcm_substream *substream,
>   			| SSC_BF(RCMR_START, SSC_START_FALLING_RF);
>   
>   		tcmr =	  SSC_BF(TCMR_STTDLY, 1)
> -			| SSC_BF(TCMR_START, SSC_START_FALLING_RF);
> +			| SSC_BF(TCMR_START, SSC_START_FALLING_TF);
>   
>   		break;
>   
> @@ -603,7 +603,7 @@ static int atmel_ssc_hw_params(struct snd_pcm_substream *substream,
>   			| SSC_BF(RCMR_START, SSC_START_RISING_RF);
>   
>   		tcmr =	  SSC_BF(TCMR_STTDLY, 1)
> -			| SSC_BF(TCMR_START, SSC_START_RISING_RF);
> +			| SSC_BF(TCMR_START, SSC_START_RISING_TF);
>   
>   		break;
>   
> diff --git a/sound/soc/atmel/atmel_ssc_dai.h b/sound/soc/atmel/atmel_ssc_dai.h
> index ae764cb541c7..efb458b6d187 100644
> --- a/sound/soc/atmel/atmel_ssc_dai.h
> +++ b/sound/soc/atmel/atmel_ssc_dai.h
> @@ -42,13 +42,20 @@
>    */
>   /* START bit field values */
>   #define SSC_START_CONTINUOUS	0
> -#define SSC_START_TX_RX		1
> +#define SSC_START_TRANSMIT	1
> +#define SSC_START_RECEIVE	1
>   #define SSC_START_LOW_RF	2
> +#define SSC_START_LOW_TF	2
>   #define SSC_START_HIGH_RF	3
> +#define SSC_START_HIGH_TF	3
>   #define SSC_START_FALLING_RF	4
> +#define SSC_START_FALLING_TF	4
>   #define SSC_START_RISING_RF	5
> +#define SSC_START_RISING_TF	5
>   #define SSC_START_LEVEL_RF	6
> +#define SSC_START_LEVEL_TF	6
>   #define SSC_START_EDGE_RF	7
> +#define SSC_START_EDGE_TF	7
>   #define SSS_START_COMPARE_0	8
>   
>   /* CKI bit field values */
> 

Wouldn't it be easier to just use SSC_START, SSC_START_LOW, 
SSC_START_HIGH, etc.? If not...

Reviewed-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com>

Thanks and best regards,
Codrin
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2019-07-25 13:28 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-22 18:27 [PATCH 0/5] ASoC: atmel: extend SSC support Michał Mirosław
2019-07-22 18:27 ` [PATCH 1/5] ASoC: atmel: enable SSC_PCM_DMA in Kconfig Michał Mirosław
2019-07-23 13:36   ` Codrin.Ciubotariu
2019-07-23 16:43     ` mirq-linux
2019-07-23 17:27       ` Codrin.Ciubotariu
2019-07-23 18:39       ` Alexandre Belloni
2019-07-23 23:25         ` mirq-linux
2019-07-25 15:25           ` Codrin.Ciubotariu
2019-08-23 15:09           ` Alexandre Belloni
2019-07-23 17:18   ` Mark Brown
2019-07-22 18:27 ` [PATCH 4/5] ASoC: atmel_ssc_dai: split TX/RX FS constants Michał Mirosław
2019-07-25 13:28   ` Codrin.Ciubotariu [this message]
2019-07-22 18:27 ` [PATCH 3/5] ASoC: atmel_ssc_dai: implement left-justified data mode Michał Mirosław
2019-07-25 13:15   ` Codrin.Ciubotariu
2019-07-22 18:27 ` [PATCH 2/5] ASoC: atmel_ssc_dai: rework DAI format configuration Michał Mirosław
2019-07-24 10:35   ` Codrin.Ciubotariu
2019-07-24 11:15     ` mirq-linux
2019-07-24 12:54       ` Codrin.Ciubotariu
2019-07-22 18:27 ` [PATCH 5/5] ASoC: atmel_ssc_dai: Enable shared FSYNC source in frame-slave mode Michał Mirosław
2019-07-25 15:02   ` Codrin.Ciubotariu
2019-07-25 18:24     ` mirq-linux
2019-07-26 10:33       ` Codrin.Ciubotariu
2019-07-26 12:08         ` mirq-linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=57d6fb37-7472-e6fc-8cb7-9832ab78a171@microchip.com \
    --to=codrin.ciubotariu@microchip.com \
    --cc=Ludovic.Desroches@microchip.com \
    --cc=alexandre.belloni@bootlin.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mirq-linux@rere.qmqm.pl \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox