Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [alsa-devel] configure.ac: remove an unnecessary libtool fix
       [not found] <1576827938019478083-webhooks-bot@alsa-project.org>
@ 2019-12-20  7:45 ` GitHub pull_request - opened
  0 siblings, 0 replies; only message in thread
From: GitHub pull_request - opened @ 2019-12-20  7:45 UTC (permalink / raw)
  To: alsa-devel

alsa-project/alsa-lib pull request #19 was opened from tanuk:

This code was added in commit 75d393a563efb578c79364a277087c6326267f52
without explaining why. I assume it was a mistake, since it looks like
the libtool problem should have gone away a long time ago. The referenced
wiki page https://wiki.debian.org/RpathIssue says:

    Since libtool 1.5.2 (released 2004-01-25), on Linux libtool no
    longer sets RPATH for any directories in the dynamic linker search
    path, so this should no longer be an issue unless upstream used a
    really old version of libtool when creating their distribution
    tarball.

This code caused problems in OpenEmbedded, where the libtool script is
named "x86_64-oe-linux-libtool" or similar rather than just "libtool",
so the sed command failed with a file not found error. Rather than
adapting the code to OpenEmbedded's peculiarities, it seems best to just
remove the unnecessary code altogether.

Signed-off-by: Tanu Kaskinen <tanuk@iki.fi>

Request URL   : https://github.com/alsa-project/alsa-lib/pull/19
Patch URL     : https://github.com/alsa-project/alsa-lib/pull/19.patch
Repository URL: https://github.com/alsa-project/alsa-lib
_______________________________________________
Alsa-devel mailing list
Alsa-devel@alsa-project.org
https://mailman.alsa-project.org/mailman/listinfo/alsa-devel

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-12-20  7:46 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1576827938019478083-webhooks-bot@alsa-project.org>
2019-12-20  7:45 ` [alsa-devel] configure.ac: remove an unnecessary libtool fix GitHub pull_request - opened

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox