From: Mark Brown <broonie@kernel.org>
To: jack.yu@realtek.com
Cc: oder_chiou@realtek.com, alsa-devel@alsa-project.org,
lars@metafoo.de, kent_chen@realtek.com, kenny_chen@realtek.com,
lgirdwood@gmail.com, derek.fang@realtek.com,
shumingf@realtek.com, mingjane_hsieh@realtek.com,
flove@realtek.com
Subject: Re: [PATCH] ASoC: rt1015: modify some structure to be static and add operation callback function for rt1015_dai
Date: Wed, 26 Feb 2020 12:26:19 +0000 [thread overview]
Message-ID: <20200226122619.GF4136@sirena.org.uk> (raw)
In-Reply-To: <20200226022827.3262-1-jack.yu@realtek.com>
[-- Attachment #1: Type: text/plain, Size: 875 bytes --]
On Wed, Feb 26, 2020 at 10:28:27AM +0800, jack.yu@realtek.com wrote:
> From: Jack Yu <jack.yu@realtek.com>
>
> 1. Add "static" for rt1015_aif_dai_ops.
> 2. Add "static" for rt1015_dai[].
> 3. Add operation callback for rt1015_dai[].
Please don't send multiple changes in a single patch, split them up into
separate patches - the callback certainly seems like it needs to be in a
different patch.
> @@ -664,7 +664,7 @@ static int rt1015_hw_params(struct snd_pcm_substream *substream,
> snd_soc_component_update_bits(component, RT1015_TDM_MASTER,
> RT1015_I2S_DL_MASK, val_len);
> snd_soc_component_update_bits(component, RT1015_CLK2,
> - RT1015_FS_PD_MASK, pre_div);
> + RT1015_FS_PD_MASK, pre_div << RT1015_FS_PD_SFT);
>
> return 0;
> }
This doesn't seem to be mentioned in the changelog and should probably
also be a separate patch?
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-02-26 12:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-26 2:28 [PATCH] ASoC: rt1015: modify some structure to be static and add operation callback function for rt1015_dai jack.yu
2020-02-26 12:26 ` Mark Brown [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226122619.GF4136@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=derek.fang@realtek.com \
--cc=flove@realtek.com \
--cc=jack.yu@realtek.com \
--cc=kenny_chen@realtek.com \
--cc=kent_chen@realtek.com \
--cc=lars@metafoo.de \
--cc=lgirdwood@gmail.com \
--cc=mingjane_hsieh@realtek.com \
--cc=oder_chiou@realtek.com \
--cc=shumingf@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox