alsa-devel.alsa-project.org archive mirror
 help / color / mirror / Atom feed
From: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <liam.r.girdwood@linux.intel.com>,
	Takashi Iwai <tiwai@suse.de>,
	alsa-devel@alsa-project.org,
	sound-open-firmware@alsa-project.org
Subject: Re: [PATCH 2/3] ASoC: add function parameters to enable forced path pruning
Date: Wed, 11 Mar 2020 14:26:58 +0100	[thread overview]
Message-ID: <20200311132658.GB5347@ubuntu> (raw)
In-Reply-To: <20200311124102.GE5411@sirena.org.uk>

On Wed, Mar 11, 2020 at 12:41:02PM +0000, Mark Brown wrote:
> On Wed, Mar 11, 2020 at 01:36:17PM +0100, Guennadi Liakhovetski wrote:
> > On Wed, Mar 11, 2020 at 12:25:31PM +0000, Mark Brown wrote:
> 
> > > It's still not clear to me what the issue is here.  If something is
> > > making a modification to the graph which needs a recheck or update I'd
> > > expect that these things happen along with that modification.  I don't
> > > understand what you're saying about not being able to reproduce
> > > scenarios or adding things "on top".
> 
> > VirtIO support. That function currently exists in the kernel, but I don't 
> > have a test-case to verify its work, to see it called and actually perform 
> > the pruning. So I don't know how it is supposed to work. And because of 
> > that I cannot fix my VirtIO use case to use that function properly, without 
> > forcing it with an additional parameter.
> 
> I think you need to include this with your VirtIO series.

That was also my original intention, personally I also would find it difficult 
to review this kind of work without context.

So, would you prefer me to drop this series completely and re-send it with the 
whole series or should I just drop #2 and resend #1 and #3?

Thanks
Guennadi

  reply	other threads:[~2020-03-11 13:28 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-09 17:07 [PATCH 0/3] [RESEND] ASoC: SOF: preparatory patches Guennadi Liakhovetski
2020-03-09 17:07 ` [PATCH 1/3] ASoC: (cosmetic) simplify dpcm_prune_paths() Guennadi Liakhovetski
2020-03-09 21:37   ` Pierre-Louis Bossart
2020-03-09 17:07 ` [PATCH 2/3] ASoC: add function parameters to enable forced path pruning Guennadi Liakhovetski
2020-03-09 21:48   ` Pierre-Louis Bossart
2020-03-10 12:45   ` Mark Brown
2020-03-11  7:41     ` Guennadi Liakhovetski
2020-03-11 12:25       ` Mark Brown
2020-03-11 12:36         ` Guennadi Liakhovetski
2020-03-11 12:41           ` Mark Brown
2020-03-11 13:26             ` Guennadi Liakhovetski [this message]
2020-03-09 17:07 ` [PATCH 3/3] ASoC: export DPCM runtime update functions Guennadi Liakhovetski
2020-03-09 21:54   ` [Sound-open-firmware] " Pierre-Louis Bossart
2020-03-09 22:05 ` [PATCH 0/3] [RESEND] ASoC: SOF: preparatory patches Pierre-Louis Bossart
2020-03-10 12:50   ` Mark Brown
2020-03-10 20:13     ` Pierre-Louis Bossart
2020-03-11 12:16       ` Mark Brown
2020-03-12 11:45     ` Guennadi Liakhovetski
2020-03-12 12:15       ` Mark Brown
2020-03-12 13:09         ` Guennadi Liakhovetski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200311132658.GB5347@ubuntu \
    --to=guennadi.liakhovetski@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=liam.r.girdwood@linux.intel.com \
    --cc=sound-open-firmware@alsa-project.org \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).