Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Allen Pais <allen.lkml@gmail.com>
To: perex@perex.cz, tiwai@suse.com, broonie@kernel.org
Cc: alsa-devel@alsa-project.org, timur@kernel.org,
	Xiubo.Lee@gmail.com, clemens@ladisch.de,
	Allen Pais <allen.lkml@gmail.com>,
	nicoleotsuka@gmail.com, Romain Perier <romain.perier@gmail.com>
Subject: [PATCH v2 09/10] ALSA: usb-audio: convert tasklets to use new tasklet_setup() API
Date: Wed,  2 Sep 2020 09:32:20 +0530	[thread overview]
Message-ID: <20200902040221.354941-10-allen.lkml@gmail.com> (raw)
In-Reply-To: <20200902040221.354941-1-allen.lkml@gmail.com>

In preparation for unconditionally passing the
struct tasklet_struct pointer to all tasklet
callbacks, switch to using the new tasklet_setup()
and from_tasklet() to pass the tasklet pointer explicitly.

Signed-off-by: Romain Perier <romain.perier@gmail.com>
Signed-off-by: Allen Pais <allen.lkml@gmail.com>
---
 sound/usb/midi.c | 7 +++----
 1 file changed, 3 insertions(+), 4 deletions(-)

diff --git a/sound/usb/midi.c b/sound/usb/midi.c
index df639fe03118..e8287a05e36b 100644
--- a/sound/usb/midi.c
+++ b/sound/usb/midi.c
@@ -344,10 +344,9 @@ static void snd_usbmidi_do_output(struct snd_usb_midi_out_endpoint *ep)
 	spin_unlock_irqrestore(&ep->buffer_lock, flags);
 }
 
-static void snd_usbmidi_out_tasklet(unsigned long data)
+static void snd_usbmidi_out_tasklet(struct tasklet_struct *t)
 {
-	struct snd_usb_midi_out_endpoint *ep =
-		(struct snd_usb_midi_out_endpoint *) data;
+	struct snd_usb_midi_out_endpoint *ep = from_tasklet(ep, t, tasklet);
 
 	snd_usbmidi_do_output(ep);
 }
@@ -1441,7 +1440,7 @@ static int snd_usbmidi_out_endpoint_create(struct snd_usb_midi *umidi,
 	}
 
 	spin_lock_init(&ep->buffer_lock);
-	tasklet_init(&ep->tasklet, snd_usbmidi_out_tasklet, (unsigned long)ep);
+	tasklet_setup(&ep->tasklet, snd_usbmidi_out_tasklet);
 	init_waitqueue_head(&ep->drain_wait);
 
 	for (i = 0; i < 0x10; ++i)
-- 
2.25.1


  parent reply	other threads:[~2020-09-02  4:08 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-02  4:02 [PATCH v2 00/10] ALSA: convert tasklets to use new Allen Pais
2020-09-02  4:02 ` [PATCH v2 01/10] ALSA: core: convert tasklets to use new tasklet_setup() API Allen Pais
2020-09-02  4:02 ` [PATCH v2 02/10] ALSA: firewire: " Allen Pais
2020-09-02  8:44   ` Takashi Sakamoto
2020-09-02  9:14     ` Takashi Iwai
2020-09-02  4:02 ` [PATCH v2 03/10] ALSA: pci/asihpi: " Allen Pais
2020-09-02  4:02 ` [PATCH v2 04/10] ALSA: riptide: " Allen Pais
2020-09-02  4:02 ` [PATCH v2 05/10] ALSA: hdsp: " Allen Pais
2020-09-02  4:02 ` [PATCH v2 06/10] ASoc: fsl_esai: " Allen Pais
2020-09-02 10:08   ` Mark Brown
2020-09-02  4:02 ` [PATCH v2 07/10] ASoC: siu: " Allen Pais
2020-09-02 10:10   ` Mark Brown
2020-09-02  4:02 ` [PATCH v2 08/10] ASoC: txx9: " Allen Pais
2020-09-02 10:10   ` Mark Brown
2020-09-02  4:02 ` Allen Pais [this message]
2020-09-02  4:02 ` [PATCH v2 10/10] ALSA: ua101: " Allen Pais
2020-09-02 11:57 ` [PATCH v2 00/10] ALSA: convert tasklets to use new Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200902040221.354941-10-allen.lkml@gmail.com \
    --to=allen.lkml@gmail.com \
    --cc=Xiubo.Lee@gmail.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=clemens@ladisch.de \
    --cc=nicoleotsuka@gmail.com \
    --cc=perex@perex.cz \
    --cc=romain.perier@gmail.com \
    --cc=timur@kernel.org \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox