From: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To: Allen Pais <allen.lkml@gmail.com>
Cc: alsa-devel@alsa-project.org, timur@kernel.org,
Xiubo.Lee@gmail.com, clemens@ladisch.de, tiwai@suse.com,
nicoleotsuka@gmail.com, broonie@kernel.org,
Romain Perier <romain.perier@gmail.com>
Subject: Re: [PATCH v2 02/10] ALSA: firewire: convert tasklets to use new tasklet_setup() API
Date: Wed, 2 Sep 2020 17:44:43 +0900 [thread overview]
Message-ID: <20200902084443.GA791585@workstation> (raw)
In-Reply-To: <20200902040221.354941-3-allen.lkml@gmail.com>
Hi,
On Wed, Sep 02, 2020 at 09:32:13AM +0530, Allen Pais wrote:
> In preparation for unconditionally passing the
> struct tasklet_struct pointer to all tasklet
> callbacks, switch to using the new tasklet_setup()
> and from_tasklet() to pass the tasklet pointer explicitly.
>
> Signed-off-by: Romain Perier <romain.perier@gmail.com>
> Signed-off-by: Allen Pais <allen.lkml@gmail.com>
> ---
> sound/firewire/amdtp-stream.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
This looks good to me.
Acked-by: Takashi Sakamoto <o-takashi@sakamocchi.jp>
To Iwai-san,
I'm review your patch in 'test/kill-tasklet' branch in sound.git[1].
Although I agree with the direction to obsolete tasklet usage with
workqueue, 'in_interrupt()' helper function is used in two lines in
'sound/firewire/amdtp-stream.c' since it's convenient to distinguish
running context (any softirq or user task). We need enough care of
the cases about which below two patches mention:
* 1dba9db0eaa6 ('ALSA: firewire-lib: permit to flush queued packets
only in process context for better PCM period granularity')
* 4a9bfafc64f4 ('ALSA: firewire-lib: Fix stall of process context
at packet error)
As long as I know, we have no helper function to distinguish workqueue
task from user task. The simple replacement is not good way in the case.
I'm investigating better solution but not find yet...
[1] https://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound.git/commit/?h=test/kill-tasklet&id=bd17f03415d44c1a69fcbb7c074c1dc86f4e8bc6
Thanks
Takashi Sakamoto
next prev parent reply other threads:[~2020-09-02 8:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-02 4:02 [PATCH v2 00/10] ALSA: convert tasklets to use new Allen Pais
2020-09-02 4:02 ` [PATCH v2 01/10] ALSA: core: convert tasklets to use new tasklet_setup() API Allen Pais
2020-09-02 4:02 ` [PATCH v2 02/10] ALSA: firewire: " Allen Pais
2020-09-02 8:44 ` Takashi Sakamoto [this message]
2020-09-02 9:14 ` Takashi Iwai
2020-09-02 4:02 ` [PATCH v2 03/10] ALSA: pci/asihpi: " Allen Pais
2020-09-02 4:02 ` [PATCH v2 04/10] ALSA: riptide: " Allen Pais
2020-09-02 4:02 ` [PATCH v2 05/10] ALSA: hdsp: " Allen Pais
2020-09-02 4:02 ` [PATCH v2 06/10] ASoc: fsl_esai: " Allen Pais
2020-09-02 10:08 ` Mark Brown
2020-09-02 4:02 ` [PATCH v2 07/10] ASoC: siu: " Allen Pais
2020-09-02 10:10 ` Mark Brown
2020-09-02 4:02 ` [PATCH v2 08/10] ASoC: txx9: " Allen Pais
2020-09-02 10:10 ` Mark Brown
2020-09-02 4:02 ` [PATCH v2 09/10] ALSA: usb-audio: " Allen Pais
2020-09-02 4:02 ` [PATCH v2 10/10] ALSA: ua101: " Allen Pais
2020-09-02 11:57 ` [PATCH v2 00/10] ALSA: convert tasklets to use new Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200902084443.GA791585@workstation \
--to=o-takashi@sakamocchi.jp \
--cc=Xiubo.Lee@gmail.com \
--cc=allen.lkml@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=clemens@ladisch.de \
--cc=nicoleotsuka@gmail.com \
--cc=romain.perier@gmail.com \
--cc=timur@kernel.org \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox