From: Hans de Goede <hdegoede@redhat.com>
To: Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Oder Chiou <oder_chiou@realtek.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.com>,
Bard Liao <bard.liao@intel.com>
Subject: [RFC 2/2] ASoC: rt5670: Add LED trigger support
Date: Mon, 15 Feb 2021 15:24:19 +0100 [thread overview]
Message-ID: <20210215142419.308651-3-hdegoede@redhat.com> (raw)
In-Reply-To: <20210215142419.308651-1-hdegoede@redhat.com>
Add support for controlling a speaker and/or microphone mute LED through
LED triggers using the new generic LED trigger module.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
---
sound/soc/codecs/rt5670.c | 10 +++++++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/sound/soc/codecs/rt5670.c b/sound/soc/codecs/rt5670.c
index feab15d0686a..9233710e3a4f 100644
--- a/sound/soc/codecs/rt5670.c
+++ b/sound/soc/codecs/rt5670.c
@@ -690,7 +690,8 @@ static const struct snd_kcontrol_new rt5670_snd_controls[] = {
/* DAC Digital Volume */
SOC_DOUBLE("DAC2 Playback Switch", RT5670_DAC_CTRL,
RT5670_M_DAC_L2_VOL_SFT, RT5670_M_DAC_R2_VOL_SFT, 1, 1),
- SOC_DOUBLE_EXT("DAC1 Playback Switch", SND_SOC_NOPM, 0, 1, 1, 0,
+ SOC_DOUBLE_EXT_ACCESS("DAC1 Playback Switch", SND_SOC_NOPM, 0, 1, 1, 0,
+ SNDRV_CTL_ELEM_ACCESS_SPK_LED,
rt5670_dac1_playback_switch_get, rt5670_dac1_playback_switch_put),
SOC_DOUBLE_TLV("DAC1 Playback Volume", RT5670_DAC1_DIG_VOL,
RT5670_L_VOL_SFT, RT5670_R_VOL_SFT,
@@ -708,8 +709,9 @@ static const struct snd_kcontrol_new rt5670_snd_controls[] = {
RT5670_INL_VOL_SFT, RT5670_INR_VOL_SFT,
31, 1, in_vol_tlv),
/* ADC Digital Volume Control */
- SOC_DOUBLE("ADC Capture Switch", RT5670_STO1_ADC_DIG_VOL,
- RT5670_L_MUTE_SFT, RT5670_R_MUTE_SFT, 1, 1),
+ SOC_DOUBLE_ACCESS("ADC Capture Switch", RT5670_STO1_ADC_DIG_VOL,
+ RT5670_L_MUTE_SFT, RT5670_R_MUTE_SFT, 1, 1,
+ SNDRV_CTL_ELEM_ACCESS_MIC_LED),
SOC_DOUBLE_TLV("ADC Capture Volume", RT5670_STO1_ADC_DIG_VOL,
RT5670_L_VOL_SFT, RT5670_R_VOL_SFT,
127, 0, adc_vol_tlv),
@@ -3253,6 +3255,8 @@ static int rt5670_i2c_probe(struct i2c_client *i2c,
}
+ snd_ctl_led_request();
+
pm_runtime_enable(&i2c->dev);
pm_request_idle(&i2c->dev);
--
2.30.1
next prev parent reply other threads:[~2021-02-15 14:25 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-15 14:24 [RFC 0/2] ASoC: rt5670: Add LED trigger support Hans de Goede
2021-02-15 14:24 ` [RFC 1/2] ASoC: Add new SOC_DOUBLE*_ACCESS() macros Hans de Goede
2021-02-15 14:24 ` Hans de Goede [this message]
2021-02-23 13:45 ` [RFC 2/2] ASoC: rt5670: Add LED trigger support Mark Brown
2021-02-23 13:59 ` Hans de Goede
2021-02-23 14:09 ` Mark Brown
2021-02-23 14:21 ` Takashi Iwai
2021-02-23 16:14 ` Jaroslav Kysela
2021-02-23 16:20 ` Takashi Iwai
2021-02-23 20:56 ` Jaroslav Kysela
2021-02-24 7:12 ` Takashi Iwai
2021-02-24 8:14 ` Jaroslav Kysela
2021-02-24 8:52 ` Takashi Iwai
2021-02-24 9:27 ` Jaroslav Kysela
2021-02-24 9:38 ` Takashi Iwai
2021-02-24 9:49 ` Jaroslav Kysela
2021-02-24 10:33 ` Takashi Iwai
2021-02-24 10:56 ` Jaroslav Kysela
2021-02-24 11:43 ` Takashi Iwai
2021-02-24 12:08 ` Jaroslav Kysela
2021-02-24 12:42 ` Takashi Iwai
2021-02-24 17:57 ` Jaroslav Kysela
2021-02-25 11:00 ` Takashi Iwai
2021-02-25 18:09 ` Jaroslav Kysela
2021-02-26 8:41 ` Takashi Iwai
2021-02-26 9:22 ` Jaroslav Kysela
2021-02-23 17:07 ` Hans de Goede
2021-02-23 17:20 ` Mark Brown
2021-02-23 19:03 ` Hans de Goede
2021-02-24 12:59 ` Mark Brown
2021-02-24 19:14 ` Hans de Goede
2021-02-24 19:36 ` Mark Brown
2021-02-24 20:09 ` Hans de Goede
2021-02-25 14:59 ` Mark Brown
2021-02-25 18:45 ` Hans de Goede
2021-03-01 13:23 ` Mark Brown
2021-03-01 13:39 ` Hans de Goede
2021-03-01 19:15 ` Mark Brown
2021-03-01 19:49 ` Hans de Goede
2021-03-01 20:43 ` Mark Brown
2021-03-01 21:26 ` Hans de Goede
2021-03-02 12:41 ` Mark Brown
2021-03-02 21:14 ` Jaroslav Kysela
2021-03-04 19:39 ` Hans de Goede
2021-03-05 13:02 ` Jaroslav Kysela
2021-03-07 13:51 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210215142419.308651-3-hdegoede@redhat.com \
--to=hdegoede@redhat.com \
--cc=alsa-devel@alsa-project.org \
--cc=bard.liao@intel.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=oder_chiou@realtek.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox