Re: [RFC 2/2] ASoC: rt5670: Add LED trigger support

[Mark Brown <broonie@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 1015 bytes --]

On Mon, Mar 01, 2021 at 02:39:46PM +0100, Hans de Goede wrote:
> On 3/1/21 2:23 PM, Mark Brown wrote:

> > I don't want to get stuck in a cycle of "why can't my system just do
> > what this other system does", or worse end up with problems due to
> > competing system requirements when patches go in on more flexible
> > devices because I didn't notice that the device wasn't a good fit for
> > this sort of thing but people have the expectation that the kernel will
> > transparently handle things.

> So what do you want / how do you want this to work ?

Off the top of my head something like writing a control name into a
sysfs file might work, it doesn't scale if you need to use multiple
controls as rt5640 does though.  We could also do something like have
drivers make a list of all output stage mutes and then use that to build
a standard global mute control which functions similarly to this one and
could be force wired to the LED trigger input, seems like a big hammer
but it'd be reasonably consistent.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]