From: Takashi Iwai <tiwai@suse.de>
To: alsa-devel@alsa-project.org
Cc: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
Subject: [PATCH 1/7] ALSA: core: Use READ_ONCE() / WRITE_ONCE() for power state change
Date: Tue, 18 May 2021 18:51:55 +0200 [thread overview]
Message-ID: <20210518165201.24376-2-tiwai@suse.de> (raw)
In-Reply-To: <20210518165201.24376-1-tiwai@suse.de>
We need proper barriers to handle the power state change of the card
from different CPUs.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
include/sound/core.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/include/sound/core.h b/include/sound/core.h
index 1f9aef0adbc9..d69dfc6c4953 100644
--- a/include/sound/core.h
+++ b/include/sound/core.h
@@ -142,12 +142,12 @@ struct snd_card {
#ifdef CONFIG_PM
static inline unsigned int snd_power_get_state(struct snd_card *card)
{
- return card->power_state;
+ return READ_ONCE(card->power_state);
}
static inline void snd_power_change_state(struct snd_card *card, unsigned int state)
{
- card->power_state = state;
+ WRITE_ONCE(card->power_state, state);
wake_up(&card->power_sleep);
}
--
2.26.2
next prev parent reply other threads:[~2021-05-18 16:53 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 16:51 [PATCH 0/7] ALSA: Prep work for PCI rescan support Takashi Iwai
2021-05-18 16:51 ` Takashi Iwai [this message]
2021-05-18 16:51 ` [PATCH 2/7] ALSA: control: Add power state check commonly for ioctl handlers Takashi Iwai
2021-05-18 18:00 ` Jaroslav Kysela
2021-05-18 19:31 ` Takashi Iwai
2021-05-18 16:51 ` [PATCH 3/7] ALSA: control: Drop superfluous snd_power_wait() calls Takashi Iwai
2021-05-18 16:51 ` [PATCH 4/7] ALSA: control: Minor optimization for SNDRV_CTL_IOCTL_POWER_STATE Takashi Iwai
2021-05-18 16:51 ` [PATCH 5/7] ALSA: control: Track in-flight control read/write/tlv accesses Takashi Iwai
2021-05-18 18:01 ` Jaroslav Kysela
2021-05-18 18:54 ` Takashi Iwai
2021-05-18 16:52 ` [PATCH 6/7] ALSA: pcm: Block the release until the system resume finishes Takashi Iwai
2021-05-18 16:52 ` [PATCH 7/7] ALSA: Drop superfluous argument from snd_power_wait() Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210518165201.24376-2-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=andrey.grodzovsky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox