From: Takashi Iwai <tiwai@suse.de>
To: alsa-devel@alsa-project.org
Cc: Andrey Grodzovsky <andrey.grodzovsky@amd.com>
Subject: [PATCH 6/7] ALSA: pcm: Block the release until the system resume finishes
Date: Tue, 18 May 2021 18:52:00 +0200 [thread overview]
Message-ID: <20210518165201.24376-7-tiwai@suse.de> (raw)
In-Reply-To: <20210518165201.24376-1-tiwai@suse.de>
The normal PCM operations are already blocked during the card power
off state in the PCM common ioctl handler, but the release isn't
covered. As the PCM stream release may also access the hardware,
let's block the release until the card power turns on.
Signed-off-by: Takashi Iwai <tiwai@suse.de>
---
sound/core/pcm_native.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/sound/core/pcm_native.c b/sound/core/pcm_native.c
index 8dbe86cf2e4f..3c6ba0dc2970 100644
--- a/sound/core/pcm_native.c
+++ b/sound/core/pcm_native.c
@@ -2799,6 +2799,10 @@ static int snd_pcm_release(struct inode *inode, struct file *file)
if (snd_BUG_ON(!substream))
return -ENXIO;
pcm = substream->pcm;
+
+ /* block until the device gets woken up as it may touch the hardware */
+ snd_power_wait(pcm->card, SNDRV_CTL_POWER_D0);
+
mutex_lock(&pcm->open_mutex);
snd_pcm_release_substream(substream);
kfree(pcm_file);
--
2.26.2
next prev parent reply other threads:[~2021-05-18 16:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-18 16:51 [PATCH 0/7] ALSA: Prep work for PCI rescan support Takashi Iwai
2021-05-18 16:51 ` [PATCH 1/7] ALSA: core: Use READ_ONCE() / WRITE_ONCE() for power state change Takashi Iwai
2021-05-18 16:51 ` [PATCH 2/7] ALSA: control: Add power state check commonly for ioctl handlers Takashi Iwai
2021-05-18 18:00 ` Jaroslav Kysela
2021-05-18 19:31 ` Takashi Iwai
2021-05-18 16:51 ` [PATCH 3/7] ALSA: control: Drop superfluous snd_power_wait() calls Takashi Iwai
2021-05-18 16:51 ` [PATCH 4/7] ALSA: control: Minor optimization for SNDRV_CTL_IOCTL_POWER_STATE Takashi Iwai
2021-05-18 16:51 ` [PATCH 5/7] ALSA: control: Track in-flight control read/write/tlv accesses Takashi Iwai
2021-05-18 18:01 ` Jaroslav Kysela
2021-05-18 18:54 ` Takashi Iwai
2021-05-18 16:52 ` Takashi Iwai [this message]
2021-05-18 16:52 ` [PATCH 7/7] ALSA: Drop superfluous argument from snd_power_wait() Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210518165201.24376-7-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=alsa-devel@alsa-project.org \
--cc=andrey.grodzovsky@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox