From: "Geoffrey D. Bennett" <g@b4.vu>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org
Subject: Re: [RFC PATCH sound] ALSA: usb-audio: scarlett2: snd_scarlett_gen2_controls_create() can be static
Date: Sun, 23 May 2021 18:43:28 +0930 [thread overview]
Message-ID: <20210523091328.GA121197@m.b4.vu> (raw)
In-Reply-To: <s5hv979ery9.wl-tiwai@suse.de>
On Sun, May 23, 2021 at 11:10:22AM +0200, Takashi Iwai wrote:
> On Sun, 23 May 2021 11:03:26 +0200,
> Geoffrey D. Bennett wrote:
> >
> > Hi Takashi,
> >
> > This patch seems legitimate to me (although I would adjust whitespace
> > so the second line doesn't go over 80 chars). Do you want to just
> > apply it as-is, or do you want me to send a second version of my patch
> > without this problem or send a new patch similar to this one?
>
> As it's an obviously correct patch, I already applied as is.
Thank you!
prev parent reply other threads:[~2021-05-23 9:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-22 18:08 [sound:for-linus 117/119] sound/usb/mixer_scarlett_gen2.c:2000:5: sparse: sparse: symbol 'snd_scarlett_gen2_controls_create' was not declared. Should it be static? kernel test robot
2021-05-22 18:09 ` [RFC PATCH sound] ALSA: usb-audio: scarlett2: snd_scarlett_gen2_controls_create() can be static kernel test robot
2021-05-23 8:32 ` Takashi Iwai
2021-05-23 9:03 ` Geoffrey D. Bennett
2021-05-23 9:10 ` Takashi Iwai
2021-05-23 9:13 ` Geoffrey D. Bennett [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210523091328.GA121197@m.b4.vu \
--to=g@b4.vu \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox