From: Mark Brown <broonie@kernel.org>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, Vinod Koul <vkoul@kernel.org>
Subject: Re: [PATCH 2/2] ALSA: compress: Initialize mutex in snd_compress_new()
Date: Wed, 14 Jul 2021 17:29:01 +0100 [thread overview]
Message-ID: <20210714162901.GF4719@sirena.org.uk> (raw)
In-Reply-To: <20210714162424.4412-3-tiwai@suse.de>
[-- Attachment #1: Type: text/plain, Size: 486 bytes --]
On Wed, Jul 14, 2021 at 06:24:24PM +0200, Takashi Iwai wrote:
> Currently the snd_compr.lock mutex isn't initialized in the API
> functions although the lock is used many places in other code in
> compress offload API. It's because the object was expected to be
> initialized via snd_compress_register(), but this was never used by
> ASoC, which is the only user. Instead, ASoC initializes the mutex by
> itself, and this is error-prone.
Reviewed-by: Mark Brown <broonie@kernel.org>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2021-07-14 16:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 16:24 [PATCH 0/2] ALSA: compress: Cleanup and a potential fix Takashi Iwai
2021-07-14 16:24 ` [PATCH 1/2] ALSA: compress: Drop unused functions Takashi Iwai
2021-07-14 16:24 ` [PATCH 2/2] ALSA: compress: Initialize mutex in snd_compress_new() Takashi Iwai
2021-07-14 16:29 ` Mark Brown [this message]
2021-07-15 3:39 ` [PATCH 0/2] ALSA: compress: Cleanup and a potential fix Vinod Koul
2021-07-15 7:51 ` Péter Ujfalusi
2021-07-15 7:56 ` Ujfalusi, Peter
2021-07-15 8:03 ` Takashi Iwai
2021-07-15 8:07 ` Péter Ujfalusi
2021-07-15 8:57 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210714162901.GF4719@sirena.org.uk \
--to=broonie@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox