Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: "Ujfalusi, Peter" <peter.ujfalusi@linux.intel.com>
Cc: Vinod Koul <vkoul@kernel.org>, Mark Brown <broonie@kernel.org>,
	P9ter Ujfalusi <peter.ujfalusi@gmail.com>,
	alsa-devel@alsa-project.org
Subject: Re: [PATCH 0/2] ALSA: compress: Cleanup and a potential fix
Date: Thu, 15 Jul 2021 10:03:40 +0200	[thread overview]
Message-ID: <s5hpmvkxaub.wl-tiwai@suse.de> (raw)
In-Reply-To: <2ac2e847-9c14-658e-8d75-0b93a8ddd0d6@linux.intel.com>

On Thu, 15 Jul 2021 09:56:59 +0200,
Ujfalusi, Peter wrote:
> 
> 
> 
> On 7/15/2021 10:51, Péter Ujfalusi wrote:
> > 
> > 
> > On 15/07/2021 06:39, Vinod Koul wrote:
> >> On 14-07-21, 18:24, Takashi Iwai wrote:
> >>> Hi,
> >>>
> >>> this series contains a couple of patches for compress-offload API, one
> >>> for a cleanup of unused API functions and another for the proper mutex
> >>> initialization.  I stumbled on the second while doing the first.
> >>
> >> Thanks for the cleanup. We never have a compress only device and it is a
> >> mix of PCM and compress FEs mostly :)
> > 
> > Actually I'm working on a series where a card would only contain nothing
> > else but a compr, no PCMs...
> 
> and I should have replied from here ;)
> 
> I'm preparing to split up the SOF into IPC clients [1] and the probes
> support (which is using compress API) is going to be moved as a separate
> client, creating it's own sound card with the single comprCxD0 (and the
> controlCx).
> 
> Is this cleanup going to prevent this?

Unless you use snd_compress_register() function, nothing can break.
And if you were to use the function together with ASoC, it must be
very wrong :)


Takashi

  reply	other threads:[~2021-07-15  8:32 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-14 16:24 [PATCH 0/2] ALSA: compress: Cleanup and a potential fix Takashi Iwai
2021-07-14 16:24 ` [PATCH 1/2] ALSA: compress: Drop unused functions Takashi Iwai
2021-07-14 16:24 ` [PATCH 2/2] ALSA: compress: Initialize mutex in snd_compress_new() Takashi Iwai
2021-07-14 16:29   ` Mark Brown
2021-07-15  3:39 ` [PATCH 0/2] ALSA: compress: Cleanup and a potential fix Vinod Koul
2021-07-15  7:51   ` Péter Ujfalusi
2021-07-15  7:56     ` Ujfalusi, Peter
2021-07-15  8:03       ` Takashi Iwai [this message]
2021-07-15  8:07         ` Péter Ujfalusi
2021-07-15  8:57 ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5hpmvkxaub.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=peter.ujfalusi@gmail.com \
    --cc=peter.ujfalusi@linux.intel.com \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox