* [PATCH -next] slimbus: qcom: Remove unnecessary print function dev_err()
@ 2022-04-14 1:44 Yang Li
2022-04-19 8:47 ` Srinivas Kandagatla
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2022-04-14 1:44 UTC (permalink / raw)
To: agross
Cc: alsa-devel, linux-arm-msm, Abaci Robot, linux-kernel,
bjorn.andersson, Yang Li, srinivas.kandagatla
The print function dev_err() is redundant because
platform_get_irq_byname() already prints an error.
Eliminate the follow coccicheck warning:
./drivers/slimbus/qcom-ctrl.c:514:2-9: line 514 is redundant because
platform_get_irq() already prints an error
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/slimbus/qcom-ctrl.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c
index ec58091fc948..c0c4f895d76e 100644
--- a/drivers/slimbus/qcom-ctrl.c
+++ b/drivers/slimbus/qcom-ctrl.c
@@ -510,10 +510,8 @@ static int qcom_slim_probe(struct platform_device *pdev)
}
ctrl->irq = platform_get_irq(pdev, 0);
- if (ctrl->irq < 0) {
- dev_err(&pdev->dev, "no slimbus IRQ\n");
+ if (ctrl->irq < 0)
return ctrl->irq;
- }
sctrl = &ctrl->ctrl;
sctrl->dev = &pdev->dev;
--
2.20.1.7.g153144c
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH -next] slimbus: qcom: Remove unnecessary print function dev_err()
2022-04-14 1:44 [PATCH -next] slimbus: qcom: Remove unnecessary print function dev_err() Yang Li
@ 2022-04-19 8:47 ` Srinivas Kandagatla
0 siblings, 0 replies; 2+ messages in thread
From: Srinivas Kandagatla @ 2022-04-19 8:47 UTC (permalink / raw)
To: Yang Li, agross
Cc: linux-arm-msm, alsa-devel, Abaci Robot, linux-kernel,
bjorn.andersson
On 14/04/2022 02:44, Yang Li wrote:
> The print function dev_err() is redundant because
> platform_get_irq_byname() already prints an error.
>
> Eliminate the follow coccicheck warning:
> ./drivers/slimbus/qcom-ctrl.c:514:2-9: line 514 is redundant because
> platform_get_irq() already prints an error
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
Applied thanks,
--srini
> ---
> drivers/slimbus/qcom-ctrl.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/slimbus/qcom-ctrl.c b/drivers/slimbus/qcom-ctrl.c
> index ec58091fc948..c0c4f895d76e 100644
> --- a/drivers/slimbus/qcom-ctrl.c
> +++ b/drivers/slimbus/qcom-ctrl.c
> @@ -510,10 +510,8 @@ static int qcom_slim_probe(struct platform_device *pdev)
> }
>
> ctrl->irq = platform_get_irq(pdev, 0);
> - if (ctrl->irq < 0) {
> - dev_err(&pdev->dev, "no slimbus IRQ\n");
> + if (ctrl->irq < 0)
> return ctrl->irq;
> - }
>
> sctrl = &ctrl->ctrl;
> sctrl->dev = &pdev->dev;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-04-19 8:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-04-14 1:44 [PATCH -next] slimbus: qcom: Remove unnecessary print function dev_err() Yang Li
2022-04-19 8:47 ` Srinivas Kandagatla
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox