[PATCH] ASoC: SOF: trace: The dtrace is only available with SOF_IPC

[PATCH] ASoC: SOF: trace: The dtrace is only available with SOF_IPC

[Peter Ujfalusi]

Currently the dtrace only supported with SOF_IPC.

Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com>
Reviewed-by: Rander Wang <rander.wang@intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
---
Hi,

I have pending series to rework the whole tracing support to allow different
tracing solutions to be plugged in for different IPC versions.

It is going to be sent at later time, until then we need to make sure that the
current dtrace is not used with IPC4.

Regards,
Peter

 sound/soc/sof/trace.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/sound/soc/sof/trace.c b/sound/soc/sof/trace.c
index ba6361b5d64b..5d171bf8a5ea 100644
--- a/sound/soc/sof/trace.c
+++ b/sound/soc/sof/trace.c
@@ -457,6 +457,10 @@ int snd_sof_init_trace(struct snd_sof_dev *sdev)
 {
 	int ret;
 
+	/* dtrace is only supported with SOF_IPC */
+	if (sdev->pdata->ipc_type != SOF_IPC)
+		sdev->dtrace_is_supported = false;
+
 	if (!sdev->dtrace_is_supported)
 		return 0;
 
-- 
2.36.0

Re: [PATCH] ASoC: SOF: trace: The dtrace is only available with SOF_IPC

[Mark Brown]

On Fri, 6 May 2022 16:02:29 +0300, Peter Ujfalusi wrote:
> Currently the dtrace only supported with SOF_IPC.
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: SOF: trace: The dtrace is only available with SOF_IPC
      commit: e813526e5535ab009e2550e1da63abf297e1af68

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark