Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
To: lgirdwood@gmail.com, broonie@kernel.org,
	pierre-louis.bossart@linux.intel.com
Cc: alsa-devel@alsa-project.org, yung-chuan.liao@linux.intel.com,
	ranjani.sridharan@linux.intel.com, kai.vehmanen@linux.intel.com
Subject: [PATCH 0/3] ASoC: SOF: Intel: Fix IMR boot race caused by early core booting
Date: Thu,  9 Jun 2022 11:59:46 +0300	[thread overview]
Message-ID: <20220609085949.29062-1-peter.ujfalusi@linux.intel.com> (raw)

Hi,

After the revisited IMR sequence patch
2a68ff846164 ("ASoC: SOF: Intel: hda: Revisit IMR boot sequence")

we have started to see random boot issues manifesting in ghost reply messages from
the DSP for a never sent message.
It turned out that an earlier commit:
d416519982cb ("ASoC: SOF: hda: don't use the core op for power up/power down")

replaced the core power up step with a full blown core power up + enable call.
The result was that we have booted the core before we would place the message
to the ROM code and based on luck and timing it got received by the (IMR) booted
firmware or in between ROM and firmware boot.

Mark, can you queue this series for 5.19 as the 2a68ff846164 is in rc1 to make
sure that we fix this random issue?

Regards,
Peter
---
Peter Ujfalusi (3):
  ASoC: SOF: Intel: hda-dsp: Expose hda_dsp_core_power_up()
  ASoC: SOF: Intel: hda-loader: Make sure that the fw load sequence is
    followed
  ASoC: SOF: Intel: hda-loader: Clarify the cl_dsp_init() flow

 sound/soc/sof/intel/hda-dsp.c    | 10 +++++++++-
 sound/soc/sof/intel/hda-loader.c | 10 +++++-----
 sound/soc/sof/intel/hda.h        |  1 +
 3 files changed, 15 insertions(+), 6 deletions(-)

-- 
2.36.1


             reply	other threads:[~2022-06-09  9:00 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-09  8:59 Peter Ujfalusi [this message]
2022-06-09  8:59 ` [PATCH 1/3] ASoC: SOF: Intel: hda-dsp: Expose hda_dsp_core_power_up() Peter Ujfalusi
2022-06-09  8:59 ` [PATCH 2/3] ASoC: SOF: Intel: hda-loader: Make sure that the fw load sequence is followed Peter Ujfalusi
2022-06-09  8:59 ` [PATCH 3/3] ASoC: SOF: Intel: hda-loader: Clarify the cl_dsp_init() flow Peter Ujfalusi
2022-06-09 15:25 ` [PATCH 0/3] ASoC: SOF: Intel: Fix IMR boot race caused by early core booting Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20220609085949.29062-1-peter.ujfalusi@linux.intel.com \
    --to=peter.ujfalusi@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=lgirdwood@gmail.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox