From: Cezary Rojewski <cezary.rojewski@intel.com>
To: alsa-devel@alsa-project.org, broonie@kernel.org
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
pierre-louis.bossart@linux.intel.com, tiwai@suse.com,
hdegoede@redhat.com, amadeuszx.slawinski@linux.intel.com
Subject: [PATCH 10/12] ASoC: Intel: avs: Replace hardcodes with SD_CTL_STREAM_RESET
Date: Thu, 7 Jul 2022 14:41:51 +0200 [thread overview]
Message-ID: <20220707124153.1858249-11-cezary.rojewski@intel.com> (raw)
In-Reply-To: <20220707124153.1858249-1-cezary.rojewski@intel.com>
Improve readability of CLDMA reset operation by making use of
already defined SD_CTL_STREAM_RESET.
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
---
sound/soc/intel/avs/cldma.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/sound/soc/intel/avs/cldma.c b/sound/soc/intel/avs/cldma.c
index d100c6ba4d8a..d7a9390b5e48 100644
--- a/sound/soc/intel/avs/cldma.c
+++ b/sound/soc/intel/avs/cldma.c
@@ -176,17 +176,17 @@ int hda_cldma_reset(struct hda_cldma *cl)
return ret;
}
- snd_hdac_stream_updateb(cl, SD_CTL, 1, 1);
- ret = snd_hdac_stream_readb_poll(cl, SD_CTL, reg, (reg & 1), AVS_CL_OP_INTERVAL_US,
- AVS_CL_OP_TIMEOUT_US);
+ snd_hdac_stream_updateb(cl, SD_CTL, SD_CTL_STREAM_RESET, SD_CTL_STREAM_RESET);
+ ret = snd_hdac_stream_readb_poll(cl, SD_CTL, reg, (reg & SD_CTL_STREAM_RESET),
+ AVS_CL_OP_INTERVAL_US, AVS_CL_OP_TIMEOUT_US);
if (ret < 0) {
dev_err(cl->dev, "cldma set SRST failed: %d\n", ret);
return ret;
}
- snd_hdac_stream_updateb(cl, SD_CTL, 1, 0);
- ret = snd_hdac_stream_readb_poll(cl, SD_CTL, reg, !(reg & 1), AVS_CL_OP_INTERVAL_US,
- AVS_CL_OP_TIMEOUT_US);
+ snd_hdac_stream_updateb(cl, SD_CTL, SD_CTL_STREAM_RESET, 0);
+ ret = snd_hdac_stream_readb_poll(cl, SD_CTL, reg, !(reg & SD_CTL_STREAM_RESET),
+ AVS_CL_OP_INTERVAL_US, AVS_CL_OP_TIMEOUT_US);
if (ret < 0) {
dev_err(cl->dev, "cldma unset SRST failed: %d\n", ret);
return ret;
--
2.25.1
next prev parent reply other threads:[~2022-07-07 12:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 12:41 [PATCH 00/12] ASoC: Intel: avs: Updates and cleanups Cezary Rojewski
2022-07-07 12:41 ` [PATCH 01/12] ASoC: Intel: avs: Register HDAudio ext-bus operations Cezary Rojewski
2022-07-07 12:41 ` [PATCH 02/12] ASoC: Intel: avs: Assign I2S gateway when parsing topology Cezary Rojewski
2022-07-07 12:41 ` [PATCH 03/12] ASoC: Intel: avs: Relax DSP core transition timings Cezary Rojewski
2022-07-07 12:41 ` [PATCH 04/12] ASoC: Intel: avs: Copy only as many RX bytes as necessary Cezary Rojewski
2022-07-07 12:41 ` [PATCH 05/12] ASoC: Intel: avs: Shield LARGE_CONFIG_GETs against zero payload_size Cezary Rojewski
2022-07-07 12:41 ` [PATCH 06/12] ASoC: Intel: avs: Block IPC channel on suspend Cezary Rojewski
2022-07-08 17:28 ` Mark Brown
2022-07-09 8:29 ` Cezary Rojewski
2022-07-07 12:41 ` [PATCH 07/12] ASoC: Intel: avs: Set max DMA segment size Cezary Rojewski
2022-07-07 12:41 ` [PATCH 08/12] ASoC: Intel: avs: Use helper function to set up DMA Cezary Rojewski
2022-07-07 12:41 ` [PATCH 09/12] ASoC: Intel: avs: Recognize FW_CFG_RESERVED Cezary Rojewski
2022-07-07 12:41 ` Cezary Rojewski [this message]
2022-07-07 12:41 ` [PATCH 11/12] ASoC: Intel: avs: Lower UNLOAD_MULTIPLE_MODULES IPC timeout Cezary Rojewski
2022-07-07 12:41 ` [PATCH 12/12] ASoC: Intel: avs: Update AVS_FW_INIT_TIMEOUT_US declaration Cezary Rojewski
2022-07-11 21:14 ` [PATCH 00/12] ASoC: Intel: avs: Updates and cleanups Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220707124153.1858249-11-cezary.rojewski@intel.com \
--to=cezary.rojewski@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox