From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org,
pierre-louis.bossart@linux.intel.com, tiwai@suse.com,
hdegoede@redhat.com, amadeuszx.slawinski@linux.intel.com
Subject: Re: [PATCH 06/12] ASoC: Intel: avs: Block IPC channel on suspend
Date: Sat, 9 Jul 2022 10:29:20 +0200 [thread overview]
Message-ID: <bea65122-f9b9-e9f5-745d-246fbf2ffe30@intel.com> (raw)
In-Reply-To: <YshpLSb+MltY+6eq@sirena.org.uk>
On 2022-07-08 7:28 PM, Mark Brown wrote:
> On Thu, Jul 07, 2022 at 02:41:47PM +0200, Cezary Rojewski wrote:
>
>> return AVS_IPC_RET(ret);
>> }
>>
>> + avs_ipc_block(adev->ipc);
>> avs_dsp_op(adev, int_control, false);
>> snd_hdac_ext_bus_ppcap_int_enable(bus, false);
>
> The fact that there's no matching change to unblock is fine since
> there's already code the paths starting the DSP which does that.
True. While it may be questioned why this line wasn't here from the get
go, in practice it was redundant - nothing was ever "asking" driver for
anything while it was asleep.
One of the next series in line is debugfs-related one. We could either
have every single file do PM manipulation on its own or allow for fileop
to fail gracefully if the device was asleep. Lately we revisited the
subject and decided to move away from the first option - not every
fileop will be resuming the device.
Regards,
Czarek
next prev parent reply other threads:[~2022-07-09 8:30 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-07 12:41 [PATCH 00/12] ASoC: Intel: avs: Updates and cleanups Cezary Rojewski
2022-07-07 12:41 ` [PATCH 01/12] ASoC: Intel: avs: Register HDAudio ext-bus operations Cezary Rojewski
2022-07-07 12:41 ` [PATCH 02/12] ASoC: Intel: avs: Assign I2S gateway when parsing topology Cezary Rojewski
2022-07-07 12:41 ` [PATCH 03/12] ASoC: Intel: avs: Relax DSP core transition timings Cezary Rojewski
2022-07-07 12:41 ` [PATCH 04/12] ASoC: Intel: avs: Copy only as many RX bytes as necessary Cezary Rojewski
2022-07-07 12:41 ` [PATCH 05/12] ASoC: Intel: avs: Shield LARGE_CONFIG_GETs against zero payload_size Cezary Rojewski
2022-07-07 12:41 ` [PATCH 06/12] ASoC: Intel: avs: Block IPC channel on suspend Cezary Rojewski
2022-07-08 17:28 ` Mark Brown
2022-07-09 8:29 ` Cezary Rojewski [this message]
2022-07-07 12:41 ` [PATCH 07/12] ASoC: Intel: avs: Set max DMA segment size Cezary Rojewski
2022-07-07 12:41 ` [PATCH 08/12] ASoC: Intel: avs: Use helper function to set up DMA Cezary Rojewski
2022-07-07 12:41 ` [PATCH 09/12] ASoC: Intel: avs: Recognize FW_CFG_RESERVED Cezary Rojewski
2022-07-07 12:41 ` [PATCH 10/12] ASoC: Intel: avs: Replace hardcodes with SD_CTL_STREAM_RESET Cezary Rojewski
2022-07-07 12:41 ` [PATCH 11/12] ASoC: Intel: avs: Lower UNLOAD_MULTIPLE_MODULES IPC timeout Cezary Rojewski
2022-07-07 12:41 ` [PATCH 12/12] ASoC: Intel: avs: Update AVS_FW_INIT_TIMEOUT_US declaration Cezary Rojewski
2022-07-11 21:14 ` [PATCH 00/12] ASoC: Intel: avs: Updates and cleanups Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bea65122-f9b9-e9f5-745d-246fbf2ffe30@intel.com \
--to=cezary.rojewski@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox