From: Peter Ujfalusi <peter.ujfalusi@linux.intel.com>
To: lgirdwood@gmail.com, broonie@kernel.org,
pierre-louis.bossart@linux.intel.com
Cc: alsa-devel@alsa-project.org, ranjani.sridharan@linux.intel.com,
kai.vehmanen@linux.intel.com
Subject: [PATCH 0/3] ASoC: SOF: Intel: Do not process IPC reply before firmware boot
Date: Tue, 12 Jul 2022 15:23:54 +0300 [thread overview]
Message-ID: <20220712122357.31282-1-peter.ujfalusi@linux.intel.com> (raw)
Hi,
By mistake a developer managed to create a 'corrupted' IPC4 firmware image which
loaded fine to the DSP and after boot it sent an IPC reply before we would have
received the FW_READY message.
It turned out that the image was an IPC3 firmware and the IPC reply was the IPC3
FW_READY notification message which got understood as an IPC4 reply message due
to the difference between the two IPC mechanism.
This caused a NULL pointer dereference since the reply memory will be allocated
after the FW_READY message.
To make sure this will not bite again, skip any spurious reply messages before
the FW_READY.
Regards,
Peter
---
Peter Ujfalusi (3):
ASoC: SOF: Intel: cnl: Do not process IPC reply before firmware boot
ASoC: SOF: Intel: hda-ipc: Do not process IPC reply before firmware
boot
ASoC: SOF: Intel: mtl: Do not process IPC reply before firmware boot
sound/soc/sof/intel/cnl.c | 37 +++++++++++++++++++++------------
sound/soc/sof/intel/hda-ipc.c | 39 ++++++++++++++++++++++-------------
sound/soc/sof/intel/mtl.c | 20 +++++++++++-------
3 files changed, 62 insertions(+), 34 deletions(-)
--
2.37.0
next reply other threads:[~2022-07-12 12:24 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-12 12:23 Peter Ujfalusi [this message]
2022-07-12 12:23 ` [PATCH 1/3] ASoC: SOF: Intel: cnl: Do not process IPC reply before firmware boot Peter Ujfalusi
2022-07-12 12:23 ` [PATCH 2/3] ASoC: SOF: Intel: hda-ipc: " Peter Ujfalusi
2022-07-12 12:23 ` [PATCH 3/3] ASoC: SOF: Intel: mtl: " Peter Ujfalusi
2022-07-12 18:22 ` [PATCH 0/3] ASoC: SOF: Intel: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220712122357.31282-1-peter.ujfalusi@linux.intel.com \
--to=peter.ujfalusi@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox