Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] ALSA: hda/realtek: Add Positivo C6300 model quirk
@ 2022-11-09 16:09 Edson Juliano Drosdeck
  2022-11-09 16:43 ` edson drosdeck
  2022-11-09 17:11 ` Takashi Iwai
  0 siblings, 2 replies; 7+ messages in thread
From: Edson Juliano Drosdeck @ 2022-11-09 16:09 UTC (permalink / raw)
  To: perex
  Cc: sbinding, tanureal, tangmeng, p.jungkamp, tcrawford, tiwai, wse,
	linux-kernel, edson.drosdeck, kai.heng.feng, alsa-devel

Positivo Master C6300 (1849:a233) require quirk for anabling headset-mic

Signed-off-by: Edson Juliano Drosdeck <edson.drosdeck@gmail.com>
---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 701a72ec5629..ad2987888966 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9608,6 +9608,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x511f, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
 	SND_PCI_QUIRK(0x17aa, 0x9e54, "LENOVO NB", ALC269_FIXUP_LENOVO_EAPD),
 	SND_PCI_QUIRK(0x1849, 0x1233, "ASRock NUC Box 1100", ALC233_FIXUP_NO_AUDIO_JACK),
+	SND_PCI_QUIRK(0x1849, 0xa233, "Positivo Master C6300", ALC233_FIXUP_HEADSET_MIC),
 	SND_PCI_QUIRK(0x19e5, 0x3204, "Huawei MACH-WX9", ALC256_FIXUP_HUAWEI_MACH_WX9_PINS),
 	SND_PCI_QUIRK(0x19e5, 0x320f, "Huawei WRT-WX9 ", ALC256_FIXUP_ASUS_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1b35, 0x1235, "CZC B20", ALC269_FIXUP_CZC_B20),
-- 
2.37.2


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] ALSA: hda/realtek: Add Positivo C6300 model quirk
  2022-11-09 16:09 Edson Juliano Drosdeck
@ 2022-11-09 16:43 ` edson drosdeck
  2022-11-09 17:11 ` Takashi Iwai
  1 sibling, 0 replies; 7+ messages in thread
From: edson drosdeck @ 2022-11-09 16:43 UTC (permalink / raw)
  To: perex
  Cc: sbinding, tanureal, tangmeng, p.jungkamp, tcrawford, tiwai, wse,
	linux-kernel, kai.heng.feng, alsa-devel

Disregard my previous email, the patch included with this email is
inaccurate and incorrect. A better and correct patch is going to be send
after this email.

Em qua., 9 de nov. de 2022 às 12:09, Edson Juliano Drosdeck <
edson.drosdeck@gmail.com> escreveu:

> Positivo Master C6300 (1849:a233) require quirk for anabling headset-mic
>
> Signed-off-by: Edson Juliano Drosdeck <edson.drosdeck@gmail.com>
> ---
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 701a72ec5629..ad2987888966 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -9608,6 +9608,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[]
> = {
>         SND_PCI_QUIRK(0x17aa, 0x511f, "Thinkpad",
> ALC298_FIXUP_TPT470_DOCK),
>         SND_PCI_QUIRK(0x17aa, 0x9e54, "LENOVO NB",
> ALC269_FIXUP_LENOVO_EAPD),
>         SND_PCI_QUIRK(0x1849, 0x1233, "ASRock NUC Box 1100",
> ALC233_FIXUP_NO_AUDIO_JACK),
> +       SND_PCI_QUIRK(0x1849, 0xa233, "Positivo Master C6300",
> ALC233_FIXUP_HEADSET_MIC),
>         SND_PCI_QUIRK(0x19e5, 0x3204, "Huawei MACH-WX9",
> ALC256_FIXUP_HUAWEI_MACH_WX9_PINS),
>         SND_PCI_QUIRK(0x19e5, 0x320f, "Huawei WRT-WX9 ",
> ALC256_FIXUP_ASUS_MIC_NO_PRESENCE),
>         SND_PCI_QUIRK(0x1b35, 0x1235, "CZC B20", ALC269_FIXUP_CZC_B20),
> --
> 2.37.2
>
>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] ALSA: hda/realtek: Add Positivo C6300 model quirk
  2022-11-09 16:09 Edson Juliano Drosdeck
  2022-11-09 16:43 ` edson drosdeck
@ 2022-11-09 17:11 ` Takashi Iwai
  2022-11-09 17:13   ` Takashi Iwai
  1 sibling, 1 reply; 7+ messages in thread
From: Takashi Iwai @ 2022-11-09 17:11 UTC (permalink / raw)
  To: Edson Juliano Drosdeck
  Cc: sbinding, tanureal, tangmeng, p.jungkamp, tcrawford, tiwai, wse,
	kai.heng.feng, alsa-devel, linux-kernel

On Wed, 09 Nov 2022 17:09:09 +0100,
Edson Juliano Drosdeck wrote:
> 
> Positivo Master C6300 (1849:a233) require quirk for anabling headset-mic
> 
> Signed-off-by: Edson Juliano Drosdeck <edson.drosdeck@gmail.com>

Thanks, applied now.


Takashi

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] ALSA: hda/realtek: Add Positivo C6300 model quirk
  2022-11-09 17:11 ` Takashi Iwai
@ 2022-11-09 17:13   ` Takashi Iwai
  0 siblings, 0 replies; 7+ messages in thread
From: Takashi Iwai @ 2022-11-09 17:13 UTC (permalink / raw)
  To: Edson Juliano Drosdeck
  Cc: sbinding, tanureal, tangmeng, p.jungkamp, tcrawford, tiwai, wse,
	kai.heng.feng, alsa-devel, linux-kernel

On Wed, 09 Nov 2022 18:11:46 +0100,
Takashi Iwai wrote:
> 
> On Wed, 09 Nov 2022 17:09:09 +0100,
> Edson Juliano Drosdeck wrote:
> > 
> > Positivo Master C6300 (1849:a233) require quirk for anabling headset-mic
> > 
> > Signed-off-by: Edson Juliano Drosdeck <edson.drosdeck@gmail.com>
> 
> Thanks, applied now.

Erm, no, as you already wrote, it's incorrect, doesn't build.
Dropped now.


Takashi

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH] ALSA: hda/realtek: Add Positivo C6300 model quirk
@ 2022-11-09 17:17 Edson Juliano Drosdeck
  2022-11-09 20:32 ` edson drosdeck
  2022-11-10  6:08 ` Takashi Iwai
  0 siblings, 2 replies; 7+ messages in thread
From: Edson Juliano Drosdeck @ 2022-11-09 17:17 UTC (permalink / raw)
  To: perex
  Cc: sbinding, tanureal, tangmeng, p.jungkamp, tcrawford, tiwai, wse,
	linux-kernel, edson.drosdeck, kai.heng.feng, alsa-devel

Positivo Master C6300 (1849:a233) require quirk for anabling headset-mic

Signed-off-by: Edson Juliano Drosdeck <edson.drosdeck@gmail.com>
---
 sound/pci/hda/patch_realtek.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 701a72ec5629..7875566d6183 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -9608,6 +9608,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x17aa, 0x511f, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
 	SND_PCI_QUIRK(0x17aa, 0x9e54, "LENOVO NB", ALC269_FIXUP_LENOVO_EAPD),
 	SND_PCI_QUIRK(0x1849, 0x1233, "ASRock NUC Box 1100", ALC233_FIXUP_NO_AUDIO_JACK),
+	SND_PCI_QUIRK(0x1849, 0xa233, "Positivo Master C6300", ALC269_FIXUP_HEADSET_MIC),
 	SND_PCI_QUIRK(0x19e5, 0x3204, "Huawei MACH-WX9", ALC256_FIXUP_HUAWEI_MACH_WX9_PINS),
 	SND_PCI_QUIRK(0x19e5, 0x320f, "Huawei WRT-WX9 ", ALC256_FIXUP_ASUS_MIC_NO_PRESENCE),
 	SND_PCI_QUIRK(0x1b35, 0x1235, "CZC B20", ALC269_FIXUP_CZC_B20),
-- 
2.37.2


^ permalink raw reply related	[flat|nested] 7+ messages in thread

* Re: [PATCH] ALSA: hda/realtek: Add Positivo C6300 model quirk
  2022-11-09 17:17 [PATCH] ALSA: hda/realtek: Add Positivo C6300 model quirk Edson Juliano Drosdeck
@ 2022-11-09 20:32 ` edson drosdeck
  2022-11-10  6:08 ` Takashi Iwai
  1 sibling, 0 replies; 7+ messages in thread
From: edson drosdeck @ 2022-11-09 20:32 UTC (permalink / raw)
  To: perex
  Cc: sbinding, tanureal, tangmeng, p.jungkamp, tcrawford, tiwai, wse,
	linux-kernel, kai.heng.feng, alsa-devel

This patch is working

Em qua., 9 de nov. de 2022 às 13:18, Edson Juliano Drosdeck <
edson.drosdeck@gmail.com> escreveu:

> Positivo Master C6300 (1849:a233) require quirk for anabling headset-mic
>
> Signed-off-by: Edson Juliano Drosdeck <edson.drosdeck@gmail.com>
> ---
>  sound/pci/hda/patch_realtek.c | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index 701a72ec5629..7875566d6183 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -9608,6 +9608,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[]
> = {
>         SND_PCI_QUIRK(0x17aa, 0x511f, "Thinkpad",
> ALC298_FIXUP_TPT470_DOCK),
>         SND_PCI_QUIRK(0x17aa, 0x9e54, "LENOVO NB",
> ALC269_FIXUP_LENOVO_EAPD),
>         SND_PCI_QUIRK(0x1849, 0x1233, "ASRock NUC Box 1100",
> ALC233_FIXUP_NO_AUDIO_JACK),
> +       SND_PCI_QUIRK(0x1849, 0xa233, "Positivo Master C6300",
> ALC269_FIXUP_HEADSET_MIC),
>         SND_PCI_QUIRK(0x19e5, 0x3204, "Huawei MACH-WX9",
> ALC256_FIXUP_HUAWEI_MACH_WX9_PINS),
>         SND_PCI_QUIRK(0x19e5, 0x320f, "Huawei WRT-WX9 ",
> ALC256_FIXUP_ASUS_MIC_NO_PRESENCE),
>         SND_PCI_QUIRK(0x1b35, 0x1235, "CZC B20", ALC269_FIXUP_CZC_B20),
> --
> 2.37.2
>
>

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH] ALSA: hda/realtek: Add Positivo C6300 model quirk
  2022-11-09 17:17 [PATCH] ALSA: hda/realtek: Add Positivo C6300 model quirk Edson Juliano Drosdeck
  2022-11-09 20:32 ` edson drosdeck
@ 2022-11-10  6:08 ` Takashi Iwai
  1 sibling, 0 replies; 7+ messages in thread
From: Takashi Iwai @ 2022-11-10  6:08 UTC (permalink / raw)
  To: Edson Juliano Drosdeck
  Cc: sbinding, tanureal, tangmeng, p.jungkamp, tcrawford, tiwai, wse,
	kai.heng.feng, alsa-devel, linux-kernel

On Wed, 09 Nov 2022 18:17:32 +0100,
Edson Juliano Drosdeck wrote:
> 
> Positivo Master C6300 (1849:a233) require quirk for anabling headset-mic
> 
> Signed-off-by: Edson Juliano Drosdeck <edson.drosdeck@gmail.com>

OK, applied this one again.  Thanks.


Takashi

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2022-11-10  6:09 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-11-09 17:17 [PATCH] ALSA: hda/realtek: Add Positivo C6300 model quirk Edson Juliano Drosdeck
2022-11-09 20:32 ` edson drosdeck
2022-11-10  6:08 ` Takashi Iwai
  -- strict thread matches above, loose matches on Subject: below --
2022-11-09 16:09 Edson Juliano Drosdeck
2022-11-09 16:43 ` edson drosdeck
2022-11-09 17:11 ` Takashi Iwai
2022-11-09 17:13   ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox