From: Cezary Rojewski <cezary.rojewski@intel.com>
To: alsa-devel@alsa-project.org, broonie@kernel.org
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
pierre-louis.bossart@linux.intel.com, tiwai@suse.com,
hdegoede@redhat.com, amadeuszx.slawinski@linux.intel.com
Subject: [PATCH 11/11] ASoC: Intel: avs: rt5682: Refactor jack handling
Date: Fri, 25 Nov 2022 19:40:32 +0100 [thread overview]
Message-ID: <20221125184032.2565979-12-cezary.rojewski@intel.com> (raw)
In-Reply-To: <20221125184032.2565979-1-cezary.rojewski@intel.com>
From: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Use link->exit() rather than pdev->remove() to unassign jack during card
unbind procedure so codec link initialization and exit procedures are
symmetrical.
Also, there is no need to perform search for codec dai in suspend_pre()
and resume_post() ourselves. Use snd_soc_card_get_codec_dai() instead.
Signed-off-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
---
sound/soc/intel/avs/boards/rt5682.c | 27 ++++++++++-----------------
1 file changed, 10 insertions(+), 17 deletions(-)
diff --git a/sound/soc/intel/avs/boards/rt5682.c b/sound/soc/intel/avs/boards/rt5682.c
index 7f9edf4cbd04..473e9fe5d0bf 100644
--- a/sound/soc/intel/avs/boards/rt5682.c
+++ b/sound/soc/intel/avs/boards/rt5682.c
@@ -120,6 +120,11 @@ static int avs_rt5682_codec_init(struct snd_soc_pcm_runtime *runtime)
return 0;
};
+static void avs_rt5682_codec_exit(struct snd_soc_pcm_runtime *rtd)
+{
+ snd_soc_component_set_jack(asoc_rtd_to_codec(rtd, 0)->component, NULL, NULL);
+}
+
static int
avs_rt5682_hw_params(struct snd_pcm_substream *substream, struct snd_pcm_hw_params *params)
{
@@ -239,30 +244,19 @@ static int avs_create_dapm_routes(struct device *dev, int ssp_port,
return 0;
}
-static int avs_card_set_jack(struct snd_soc_card *card, struct snd_soc_jack *jack)
-{
- struct snd_soc_component *component;
-
- for_each_card_components(card, component)
- snd_soc_component_set_jack(component, jack, NULL);
- return 0;
-}
-
-static int avs_card_remove(struct snd_soc_card *card)
-{
- return avs_card_set_jack(card, NULL);
-}
-
static int avs_card_suspend_pre(struct snd_soc_card *card)
{
- return avs_card_set_jack(card, NULL);
+ struct snd_soc_dai *codec_dai = snd_soc_card_get_codec_dai(card, AVS_RT5682_CODEC_DAI_NAME);
+
+ return snd_soc_component_set_jack(codec_dai->component, NULL, NULL);
}
static int avs_card_resume_post(struct snd_soc_card *card)
{
+ struct snd_soc_dai *codec_dai = snd_soc_card_get_codec_dai(card, AVS_RT5682_CODEC_DAI_NAME);
struct snd_soc_jack *jack = snd_soc_card_get_drvdata(card);
- return avs_card_set_jack(card, jack);
+ return snd_soc_component_set_jack(codec_dai->component, jack, NULL);
}
static int avs_rt5682_probe(struct platform_device *pdev)
@@ -306,7 +300,6 @@ static int avs_rt5682_probe(struct platform_device *pdev)
card->name = "avs_rt5682";
card->dev = dev;
card->owner = THIS_MODULE;
- card->remove = avs_card_remove;
card->suspend_pre = avs_card_suspend_pre;
card->resume_post = avs_card_resume_post;
card->dai_link = dai_link;
--
2.25.1
next prev parent reply other threads:[~2022-11-25 18:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 18:40 [PATCH 00/11] ASoC: Intel: avs: Refactor jack handling Cezary Rojewski
2022-11-25 18:40 ` [PATCH 01/11] ASoC: Intel: bdw_rt286: " Cezary Rojewski
2022-11-25 18:40 ` [PATCH 02/11] ASoC: Intel: avs: da7219: " Cezary Rojewski
2022-11-25 18:40 ` [PATCH 03/11] ASoC: Intel: avs: nau8825: " Cezary Rojewski
2022-11-25 18:40 ` [PATCH 04/11] ASoC: Intel: avs: rt274: Refer to DAI name through a constant Cezary Rojewski
2022-11-25 18:40 ` [PATCH 05/11] ASoC: Intel: avs: rt274: Refactor jack handling Cezary Rojewski
2022-11-25 18:40 ` [PATCH 06/11] ASoC: Intel: avs: rt286: Add define for codec DAI name Cezary Rojewski
2022-11-25 18:40 ` [PATCH 07/11] ASoC: Intel: avs: rt286: Refactor jack handling Cezary Rojewski
2022-11-25 18:40 ` [PATCH 08/11] ASoC: Intel: avs: rt298: Add define for codec DAI name Cezary Rojewski
2022-11-25 18:40 ` [PATCH 09/11] ASoC: Intel: avs: rt298: Refactor jack handling Cezary Rojewski
2022-11-25 18:40 ` [PATCH 10/11] ASoC: Intel: avs: rt5682: Add define for codec DAI name Cezary Rojewski
2022-11-29 16:24 ` Mark Brown
2022-11-29 16:31 ` Amadeusz Sławiński
2022-11-25 18:40 ` Cezary Rojewski [this message]
2022-11-29 16:57 ` [PATCH 00/11] ASoC: Intel: avs: Refactor jack handling Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221125184032.2565979-12-cezary.rojewski@intel.com \
--to=cezary.rojewski@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox