From: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
To: Mark Brown <broonie@kernel.org>,
Cezary Rojewski <cezary.rojewski@intel.com>
Cc: hdegoede@redhat.com, alsa-devel@alsa-project.org,
pierre-louis.bossart@linux.intel.com, tiwai@suse.com
Subject: Re: [PATCH 10/11] ASoC: Intel: avs: rt5682: Add define for codec DAI name
Date: Tue, 29 Nov 2022 17:31:13 +0100 [thread overview]
Message-ID: <2be35f9b-089b-581d-2982-8b0e1a91b58f@linux.intel.com> (raw)
In-Reply-To: <Y4YySIFSZB5/NfYh@sirena.org.uk>
On 11/29/2022 5:24 PM, Mark Brown wrote:
> On Fri, Nov 25, 2022 at 07:40:31PM +0100, Cezary Rojewski wrote:
>> From: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
>>
>> Following commits will make use of it to find codec DAI, define it
>> first.
>
> This breaks an x86 allmodconfig build:
>
> /build/stage/linux/sound/soc/intel/avs/boards/rt5682.c: In function ‘avs_create_dai_link’:
> /build/stage/linux/sound/soc/intel/avs/boards/rt5682.c:198:20: error: ‘avs_rt5682_codec_exit’ undeclared (first use in this function); did you mean ‘avs_rt5682_codec_init’?
> 198 | dl->exit = avs_rt5682_codec_exit;
> | ^~~~~~~~~~~~~~~~~~~~~
> | avs_rt5682_codec_init
>
> and looks out of place in this commit, it at least deserves calling out
> in the commit log?
Oops.. that seems like patch split gone wrong, it is added in following
commit. Other patches add dl->exit in the "second" patch, so this chunk
should be part of patch 11, instead of this one.
next prev parent reply other threads:[~2022-11-29 16:33 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-25 18:40 [PATCH 00/11] ASoC: Intel: avs: Refactor jack handling Cezary Rojewski
2022-11-25 18:40 ` [PATCH 01/11] ASoC: Intel: bdw_rt286: " Cezary Rojewski
2022-11-25 18:40 ` [PATCH 02/11] ASoC: Intel: avs: da7219: " Cezary Rojewski
2022-11-25 18:40 ` [PATCH 03/11] ASoC: Intel: avs: nau8825: " Cezary Rojewski
2022-11-25 18:40 ` [PATCH 04/11] ASoC: Intel: avs: rt274: Refer to DAI name through a constant Cezary Rojewski
2022-11-25 18:40 ` [PATCH 05/11] ASoC: Intel: avs: rt274: Refactor jack handling Cezary Rojewski
2022-11-25 18:40 ` [PATCH 06/11] ASoC: Intel: avs: rt286: Add define for codec DAI name Cezary Rojewski
2022-11-25 18:40 ` [PATCH 07/11] ASoC: Intel: avs: rt286: Refactor jack handling Cezary Rojewski
2022-11-25 18:40 ` [PATCH 08/11] ASoC: Intel: avs: rt298: Add define for codec DAI name Cezary Rojewski
2022-11-25 18:40 ` [PATCH 09/11] ASoC: Intel: avs: rt298: Refactor jack handling Cezary Rojewski
2022-11-25 18:40 ` [PATCH 10/11] ASoC: Intel: avs: rt5682: Add define for codec DAI name Cezary Rojewski
2022-11-29 16:24 ` Mark Brown
2022-11-29 16:31 ` Amadeusz Sławiński [this message]
2022-11-25 18:40 ` [PATCH 11/11] ASoC: Intel: avs: rt5682: Refactor jack handling Cezary Rojewski
2022-11-29 16:57 ` [PATCH 00/11] ASoC: Intel: avs: " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2be35f9b-089b-581d-2982-8b0e1a91b58f@linux.intel.com \
--to=amadeuszx.slawinski@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=hdegoede@redhat.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox