From: Charles Keepax <ckeepax@opensource.cirrus.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
Linux-ALSA <alsa-devel@alsa-project.org>,
Heiko Stuebner <heiko@sntech.de>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
Mark Brown <broonie@kernel.org>,
Thierry Reding <thierry.reding@gmail.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Colin Ian King <colin.i.king@gmail.com>
Subject: Re: [PATCH 25/25] ASoC: soc-dai.h: cleanup Playback/Capture data for snd_soc_dai
Date: Fri, 20 Jan 2023 11:40:51 +0000 [thread overview]
Message-ID: <20230120114051.GV36097@ediswmail.ad.cirrus.com> (raw)
In-Reply-To: <87a62dk7pt.wl-kuninori.morimoto.gx@renesas.com>
On Fri, Jan 20, 2023 at 07:04:14AM +0000, Kuninori Morimoto wrote:
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Current snd_soc_dai has data for Playback/Capture, but it is very
> random. Someone is array (A), someone is playback/capture (B),
> and someone is tx/rx (C);
>
> struct snd_soc_dai {
> ...
> (A) unsigned int stream_active[SNDRV_PCM_STREAM_LAST + 1];
>
> (B) struct snd_soc_dapm_widget *playback_widget;
> (B) struct snd_soc_dapm_widget *capture_widget;
>
> (B) void *playback_dma_data;
> (B) void *capture_dma_data;
>
> ...
>
> (C) unsigned int tx_mask;
> (C) unsigned int rx_mask;
> };
>
> Because of it, the code was very complicated.
> This patch creates new data structure to merge these into one,
> and tidyup the code.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
Reviewed-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Thanks,
Charles
prev parent reply other threads:[~2023-01-20 11:41 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 6:56 [PATCH 00/25] ASoC: use helper function and cleanup Kuninori Morimoto
2023-01-20 7:01 ` [PATCH 02/25] ASoC: soc-dai.h: add snd_soc_dai_dma_data_set/get() for low level Kuninori Morimoto
2023-01-20 11:13 ` Charles Keepax
2023-01-20 7:01 ` [PATCH 03/25] ASoC: soc-dai.h: add snd_soc_dai_tdm_mask_set/get() helper Kuninori Morimoto
2023-01-20 11:14 ` Charles Keepax
2023-01-20 7:02 ` [PATCH 04/25] ASoC: soc-dai.h: add snd_soc_dai_get/set_widget_playback/capture() helper Kuninori Morimoto
2023-01-20 11:14 ` Charles Keepax
2023-01-20 7:02 ` [PATCH 05/25] ASoC: soc.h: add snd_soc_card_is_instantiated() helper Kuninori Morimoto
2023-01-20 11:14 ` Charles Keepax
2023-01-20 7:02 ` [PATCH 06/25] ASoC: hdmi-codec: use helper function Kuninori Morimoto
2023-01-20 7:02 ` [PATCH 07/25] ASoC: hda: " Kuninori Morimoto
2023-01-20 7:02 ` [PATCH 08/25] ASoC: max: " Kuninori Morimoto
2023-01-20 7:02 ` [PATCH 09/25] ASoC: rt: " Kuninori Morimoto
2023-01-20 7:02 ` [PATCH 10/25] ASoC: cirrus: " Kuninori Morimoto
2023-01-20 7:02 ` [PATCH 11/25] ASoC: spear: " Kuninori Morimoto
2023-01-20 7:02 ` [PATCH 12/25] ASoC: sdw-mockup: " Kuninori Morimoto
2023-01-20 7:02 ` [PATCH 13/25] ASoC: intel: " Kuninori Morimoto
2023-01-20 7:03 ` [PATCH 14/25] ASoC: mediatek: " Kuninori Morimoto
2023-01-20 7:03 ` [PATCH 15/25] ASoC: meson: " Kuninori Morimoto
2023-01-20 7:03 ` [PATCH 16/25] ASoC: rockchip: " Kuninori Morimoto
2023-01-20 7:03 ` [PATCH 17/25] ASoC: sof: " Kuninori Morimoto
2023-01-20 7:03 ` [PATCH 18/25] ASoC: tegra: " Kuninori Morimoto
2023-01-20 7:03 ` [PATCH 19/25] ASoC: ti: " Kuninori Morimoto
2023-01-20 7:03 ` [PATCH 20/25] ASoC: soc-core.c: " Kuninori Morimoto
2023-01-20 10:30 ` Charles Keepax
2023-01-20 7:03 ` [PATCH 21/25] ASoC: soc-dapm.c: " Kuninori Morimoto
2023-01-20 10:36 ` Charles Keepax
2023-01-20 7:03 ` [PATCH 22/25] ASoC: soc-dai.c: " Kuninori Morimoto
2023-01-20 8:00 ` Amadeusz Sławiński
2023-01-22 23:01 ` Kuninori Morimoto
2023-01-20 7:04 ` [PATCH 23/25] ASoC: soc-pcm.c: " Kuninori Morimoto
2023-01-20 11:09 ` Charles Keepax
2023-01-20 7:04 ` [PATCH 24/25] ASoC: soc-topology.c: " Kuninori Morimoto
2023-01-20 7:04 ` [PATCH 25/25] ASoC: soc-dai.h: cleanup Playback/Capture data for snd_soc_dai Kuninori Morimoto
2023-01-20 11:40 ` Charles Keepax [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230120114051.GV36097@ediswmail.ad.cirrus.com \
--to=ckeepax@opensource.cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=colin.i.king@gmail.com \
--cc=daniel.baluta@nxp.com \
--cc=frattaroli.nicolas@gmail.com \
--cc=heiko@sntech.de \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=jonathanh@nvidia.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=thierry.reding@gmail.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox