From: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
Mark Brown <broonie@kernel.org>
Cc: Jiapeng Chong <jiapeng.chong@linux.alibaba.com>,
Linux-ALSA <alsa-devel@alsa-project.org>,
Charles Keepax <ckeepax@opensource.cirrus.com>,
Heiko Stuebner <heiko@sntech.de>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
Jonathan Hunter <jonathanh@nvidia.com>,
Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
Thierry Reding <thierry.reding@gmail.com>,
Daniel Baluta <daniel.baluta@nxp.com>,
Colin Ian King <colin.i.king@gmail.com>
Subject: Re: [PATCH 22/25] ASoC: soc-dai.c: use helper function
Date: Fri, 20 Jan 2023 09:00:55 +0100 [thread overview]
Message-ID: <6f047ec5-4055-761d-c1ea-c2d0b606e53a@linux.intel.com> (raw)
In-Reply-To: <87edrpk7qb.wl-kuninori.morimoto.gx@renesas.com>
On 1/20/2023 8:03 AM, Kuninori Morimoto wrote:
>
> From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
>
> Current ASoC has many helper function.
> This patch use it.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> sound/soc/soc-dai.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> diff --git a/sound/soc/soc-dai.c b/sound/soc/soc-dai.c
> index 29a75fdf90e0..e01b87ea04d4 100644
> --- a/sound/soc/soc-dai.c
> +++ b/sound/soc/soc-dai.c
> @@ -267,6 +267,11 @@ int snd_soc_dai_set_tdm_slot(struct snd_soc_dai *dai,
> int slots, int slot_width)
> {
> int ret = -ENOTSUPP;
> + int stream;
> + unsigned int tdm_mask[] = {
> + tx_mask,
> + rx_mask,
> + };
>
> if (dai->driver->ops &&
> dai->driver->ops->xlate_tdm_slot_mask)
> @@ -275,8 +280,8 @@ int snd_soc_dai_set_tdm_slot(struct snd_soc_dai *dai,
> else
> snd_soc_xlate_tdm_slot_mask(slots, &tx_mask, &rx_mask);
>
> - dai->tx_mask = tx_mask;
> - dai->rx_mask = rx_mask;
> + for_each_pcm_streams(stream)
> + snd_soc_dai_tdm_mask_set(dai, stream, tdm_mask[stream]);
Does this work? There are functions earlier which modify the values of
tx_mask/rx_mask and you copy their old values on tdm_mask[] init?
>
> if (dai->driver->ops &&
> dai->driver->ops->set_tdm_slot)
next prev parent reply other threads:[~2023-01-20 8:02 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-20 6:56 [PATCH 00/25] ASoC: use helper function and cleanup Kuninori Morimoto
2023-01-20 7:01 ` [PATCH 02/25] ASoC: soc-dai.h: add snd_soc_dai_dma_data_set/get() for low level Kuninori Morimoto
2023-01-20 11:13 ` Charles Keepax
2023-01-20 7:01 ` [PATCH 03/25] ASoC: soc-dai.h: add snd_soc_dai_tdm_mask_set/get() helper Kuninori Morimoto
2023-01-20 11:14 ` Charles Keepax
2023-01-20 7:02 ` [PATCH 04/25] ASoC: soc-dai.h: add snd_soc_dai_get/set_widget_playback/capture() helper Kuninori Morimoto
2023-01-20 11:14 ` Charles Keepax
2023-01-20 7:02 ` [PATCH 05/25] ASoC: soc.h: add snd_soc_card_is_instantiated() helper Kuninori Morimoto
2023-01-20 11:14 ` Charles Keepax
2023-01-20 7:02 ` [PATCH 06/25] ASoC: hdmi-codec: use helper function Kuninori Morimoto
2023-01-20 7:02 ` [PATCH 07/25] ASoC: hda: " Kuninori Morimoto
2023-01-20 7:02 ` [PATCH 08/25] ASoC: max: " Kuninori Morimoto
2023-01-20 7:02 ` [PATCH 09/25] ASoC: rt: " Kuninori Morimoto
2023-01-20 7:02 ` [PATCH 10/25] ASoC: cirrus: " Kuninori Morimoto
2023-01-20 7:02 ` [PATCH 11/25] ASoC: spear: " Kuninori Morimoto
2023-01-20 7:02 ` [PATCH 12/25] ASoC: sdw-mockup: " Kuninori Morimoto
2023-01-20 7:02 ` [PATCH 13/25] ASoC: intel: " Kuninori Morimoto
2023-01-20 7:03 ` [PATCH 14/25] ASoC: mediatek: " Kuninori Morimoto
2023-01-20 7:03 ` [PATCH 15/25] ASoC: meson: " Kuninori Morimoto
2023-01-20 7:03 ` [PATCH 16/25] ASoC: rockchip: " Kuninori Morimoto
2023-01-20 7:03 ` [PATCH 17/25] ASoC: sof: " Kuninori Morimoto
2023-01-20 7:03 ` [PATCH 18/25] ASoC: tegra: " Kuninori Morimoto
2023-01-20 7:03 ` [PATCH 19/25] ASoC: ti: " Kuninori Morimoto
2023-01-20 7:03 ` [PATCH 20/25] ASoC: soc-core.c: " Kuninori Morimoto
2023-01-20 10:30 ` Charles Keepax
2023-01-20 7:03 ` [PATCH 21/25] ASoC: soc-dapm.c: " Kuninori Morimoto
2023-01-20 10:36 ` Charles Keepax
2023-01-20 7:03 ` [PATCH 22/25] ASoC: soc-dai.c: " Kuninori Morimoto
2023-01-20 8:00 ` Amadeusz Sławiński [this message]
2023-01-22 23:01 ` Kuninori Morimoto
2023-01-20 7:04 ` [PATCH 23/25] ASoC: soc-pcm.c: " Kuninori Morimoto
2023-01-20 11:09 ` Charles Keepax
2023-01-20 7:04 ` [PATCH 24/25] ASoC: soc-topology.c: " Kuninori Morimoto
2023-01-20 7:04 ` [PATCH 25/25] ASoC: soc-dai.h: cleanup Playback/Capture data for snd_soc_dai Kuninori Morimoto
2023-01-20 11:40 ` Charles Keepax
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f047ec5-4055-761d-c1ea-c2d0b606e53a@linux.intel.com \
--to=amadeuszx.slawinski@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=ckeepax@opensource.cirrus.com \
--cc=colin.i.king@gmail.com \
--cc=daniel.baluta@nxp.com \
--cc=frattaroli.nicolas@gmail.com \
--cc=heiko@sntech.de \
--cc=jiapeng.chong@linux.alibaba.com \
--cc=jonathanh@nvidia.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=thierry.reding@gmail.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox