From: Jaroslav Kysela <perex@perex.cz>
To: ALSA development <alsa-devel@alsa-project.org>
Subject: [PATCH alsa-lib 2/4] pcm: hw: add drain_silence configuration keyword
Date: Tue, 2 May 2023 13:50:08 +0200 [thread overview]
Message-ID: <20230502115010.986325-3-perex@perex.cz> (raw)
In-Reply-To: <20230502115010.986325-1-perex@perex.cz>
# Add silence in drain (-1 = auto /default/, 0 = off, > 0 silenced frames)
[drain_silence INT]
Signed-off-by: Jaroslav Kysela <perex@perex.cz>
---
src/pcm/pcm_hw.c | 26 ++++++++++++++++++++++++--
1 file changed, 24 insertions(+), 2 deletions(-)
diff --git a/src/pcm/pcm_hw.c b/src/pcm/pcm_hw.c
index d8f32bd9..30ff843c 100644
--- a/src/pcm/pcm_hw.c
+++ b/src/pcm/pcm_hw.c
@@ -111,6 +111,7 @@ typedef struct {
int max;
} rates;
int channels;
+ int drain_silence;
/* for chmap */
unsigned int chmap_caps;
snd_pcm_chmap_query_t **chmap_override;
@@ -738,8 +739,16 @@ static int snd_pcm_hw_drain(snd_pcm_t *pcm)
if (pcm->stream != SND_PCM_STREAM_PLAYBACK)
goto __skip_silence;
- /* compute end silence size, align to period size + extra time */
+ if (hw->drain_silence == 0)
+ goto __skip_silence;
snd_pcm_sw_params_current_no_lock(pcm, &sw_params);
+ if (hw->drain_silence > 0) {
+ silence_size = hw->drain_silence;
+ if (silence_size > pcm->buffer_size)
+ silence_size = pcm->buffer_size;
+ goto __manual_silence;
+ }
+ /* compute end silence size, align to period size + extra time */
if ((pcm->boundary % pcm->period_size) == 0) {
silence_size = pcm->period_size - (*pcm->appl.ptr % pcm->period_size);
if (silence_size == pcm->period_size)
@@ -752,6 +761,7 @@ static int snd_pcm_hw_drain(snd_pcm_t *pcm)
silence_size = pcm->period_size;
}
silence_size += pcm->rate / 10; /* 1/10th of second */
+__manual_silence:
if (sw_params.silence_size < silence_size) {
/* fill the silence soon as possible (in the bellow ioctl
* or the next period wake up)
@@ -1818,6 +1828,7 @@ pcm.name {
[rate INT] # Restrict only to the given rate
or [rate [INT INT]] # Restrict only to the given rate range (min max)
[chmap MAP] # Override channel maps; MAP is a string array
+ [drain_silence INT] # Add silence in drain (-1 = auto /default/, 0 = off, > 0 silenced frames)
}
\endcode
@@ -1850,7 +1861,7 @@ int _snd_pcm_hw_open(snd_pcm_t **pcmp, const char *name,
long card = -1, device = 0, subdevice = -1;
const char *str;
int err, sync_ptr_ioctl = 0;
- int min_rate = 0, max_rate = 0, channels = 0;
+ int min_rate = 0, max_rate = 0, channels = 0, drain_silence = -1;
snd_pcm_format_t format = SND_PCM_FORMAT_UNKNOWN;
snd_config_t *n;
int nonblock = 1; /* non-block per default */
@@ -1991,6 +2002,16 @@ int _snd_pcm_hw_open(snd_pcm_t **pcmp, const char *name,
}
continue;
}
+ if (strcmp(id, "drain_silence") == 0) {
+ long val;
+ err = snd_config_get_integer(n, &val);
+ if (err < 0) {
+ SNDERR("Invalid type for %s", id);
+ goto fail;
+ }
+ drain_silence = val;
+ continue;
+ }
SNDERR("Unknown field %s", id);
err = -EINVAL;
goto fail;
@@ -2033,6 +2054,7 @@ int _snd_pcm_hw_open(snd_pcm_t **pcmp, const char *name,
}
if (chmap)
hw->chmap_override = chmap;
+ hw->drain_silence = drain_silence;
return 0;
--
2.39.2
next prev parent reply other threads:[~2023-05-02 11:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 11:50 [PATCH alsa-lib 0/4] pcm: hw: implement explicit silencing for snd_pcm_drain Jaroslav Kysela
2023-05-02 11:50 ` [PATCH alsa-lib 1/4] pcm: hw: setup explicit silencing for snd_pcm_drain by default Jaroslav Kysela
2023-05-03 11:20 ` Oswald Buddenhagen
2023-05-03 20:19 ` Oswald Buddenhagen
2023-05-03 20:31 ` Jaroslav Kysela
2023-05-05 18:56 ` Oswald Buddenhagen
2023-05-02 11:50 ` Jaroslav Kysela [this message]
2023-05-03 11:24 ` [PATCH alsa-lib 2/4] pcm: hw: add drain_silence configuration keyword Oswald Buddenhagen
2023-05-03 14:22 ` Jaroslav Kysela
2023-05-03 15:39 ` Oswald Buddenhagen
2023-05-02 11:50 ` [PATCH alsa-lib 3/4] pcm: hw: introduce SNDRV_PCM_INFO_PERFECT_DRAIN Jaroslav Kysela
2023-05-03 11:25 ` Oswald Buddenhagen
2023-05-04 8:18 ` Takashi Iwai
2023-05-04 8:31 ` Jaroslav Kysela
2023-05-04 12:50 ` Takashi Iwai
2023-05-02 11:50 ` [PATCH alsa-lib 4/4] pcm: hw: introduce SNDRV_PCM_HW_PARAMS_DRAIN_SILENCE Jaroslav Kysela
2023-05-03 11:26 ` Oswald Buddenhagen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230502115010.986325-3-perex@perex.cz \
--to=perex@perex.cz \
--cc=alsa-devel@alsa-project.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox