From: Oswald Buddenhagen <oswald.buddenhagen@gmx.de>
To: Jaroslav Kysela <perex@perex.cz>
Cc: ALSA development <alsa-devel@alsa-project.org>
Subject: Re: [PATCH alsa-lib 2/4] pcm: hw: add drain_silence configuration keyword
Date: Wed, 3 May 2023 13:24:42 +0200 [thread overview]
Message-ID: <ZFJEers7NBjf5dCu@ugly> (raw)
In-Reply-To: <20230502115010.986325-3-perex@perex.cz>
On Tue, May 02, 2023 at 01:50:08PM +0200, Jaroslav Kysela wrote:
> # Add silence in drain (-1 = auto /default/, 0 = off, > 0 silenced frames)
> [drain_silence INT]
>
i find this wholly inadequate as a description.
specifically, it's missing a motivation.
and how would one use this in a meaningful way, given that the actual
silence size is dependent on the period size and preferably the pointer
alignment?
what i could imagine _hypothetically_ making sense is making the 1/10th
sec "overshoot" configurable, as it's hardware-dependent. but in
practice, i don't see how that would be actually useful, as the cost of
doing too much is negligible, and the default you chose seems more than
safe enough.
regards
next prev parent reply other threads:[~2023-05-03 11:26 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 11:50 [PATCH alsa-lib 0/4] pcm: hw: implement explicit silencing for snd_pcm_drain Jaroslav Kysela
2023-05-02 11:50 ` [PATCH alsa-lib 1/4] pcm: hw: setup explicit silencing for snd_pcm_drain by default Jaroslav Kysela
2023-05-03 11:20 ` Oswald Buddenhagen
2023-05-03 20:19 ` Oswald Buddenhagen
2023-05-03 20:31 ` Jaroslav Kysela
2023-05-05 18:56 ` Oswald Buddenhagen
2023-05-02 11:50 ` [PATCH alsa-lib 2/4] pcm: hw: add drain_silence configuration keyword Jaroslav Kysela
2023-05-03 11:24 ` Oswald Buddenhagen [this message]
2023-05-03 14:22 ` Jaroslav Kysela
2023-05-03 15:39 ` Oswald Buddenhagen
2023-05-02 11:50 ` [PATCH alsa-lib 3/4] pcm: hw: introduce SNDRV_PCM_INFO_PERFECT_DRAIN Jaroslav Kysela
2023-05-03 11:25 ` Oswald Buddenhagen
2023-05-04 8:18 ` Takashi Iwai
2023-05-04 8:31 ` Jaroslav Kysela
2023-05-04 12:50 ` Takashi Iwai
2023-05-02 11:50 ` [PATCH alsa-lib 4/4] pcm: hw: introduce SNDRV_PCM_HW_PARAMS_DRAIN_SILENCE Jaroslav Kysela
2023-05-03 11:26 ` Oswald Buddenhagen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZFJEers7NBjf5dCu@ugly \
--to=oswald.buddenhagen@gmx.de \
--cc=alsa-devel@alsa-project.org \
--cc=perex@perex.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox