From: Rob Herring <robh@kernel.org>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Mark Brown <broonie@kernel.org>,
Saravana Kannan <saravanak@google.com>,
Linux-ALSA <alsa-devel@alsa-project.org>,
devicetree@vger.kernel.org
Subject: Re: [PATCH v2] ASoC: dt-bindings: renesas,rsnd: add post-init-providers property
Date: Mon, 9 Sep 2024 09:22:26 -0500 [thread overview]
Message-ID: <20240909142226.GA4185128-robh@kernel.org> (raw)
In-Reply-To: <871q1zkmrc.wl-kuninori.morimoto.gx@renesas.com>
On Wed, Sep 04, 2024 at 11:44:08PM +0000, Kuninori Morimoto wrote:
> At least if rsnd is using DPCM connection with Audio-Graph-Card2,
> fw_devlink might doesn't have enough information to break the cycle
> (Same problem might occur with Multi-CPU/Codec or Codec2Codec).
> In such case, rsnd driver will not be probed.
> Add post-init-providers support to break the link cycle.
>
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> v1 -> v2
> - remove basic description/type
> - add detail description
> - update git-log
>
> Documentation/devicetree/bindings/sound/renesas,rsnd.yaml | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> index 07ec6247d9def..458877ce4aa42 100644
> --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> @@ -112,6 +112,13 @@ properties:
> description: List of necessary clock names.
> # details are defined below
>
> + post-init-providers:
> + description: |
Don't need '|' if there's no formatting.
> + At least if rsnd is using DPCM connection with Audio-Graph-Card2, fw_devlink might doesn't
> + have enough information to break the cycle. rsnd driver will not be probed in such case.
Wrap lines at 80, not 100 unless there's good reason to extend them.
> + Add post-init-providers property to indicate which link in the cycle to break.
That describes every use of post-init-providers. Drop.
> + Same problem might occur with Multi-CPU/Codec or Codec2Codec.
> +
> # ports is below
> port:
> $ref: audio-graph-port.yaml#/definitions/port-base
> --
> 2.43.0
>
prev parent reply other threads:[~2024-09-09 14:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-04 23:44 [PATCH v2] ASoC: dt-bindings: renesas,rsnd: add post-init-providers property Kuninori Morimoto
2024-09-09 14:22 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240909142226.GA4185128-robh@kernel.org \
--to=robh@kernel.org \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=saravanak@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox