Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2] ASoC: dt-bindings: renesas,rsnd: add post-init-providers property
@ 2024-09-04 23:44 Kuninori Morimoto
  2024-09-09 14:22 ` Rob Herring
  0 siblings, 1 reply; 2+ messages in thread
From: Kuninori Morimoto @ 2024-09-04 23:44 UTC (permalink / raw)
  To: Mark Brown, Rob Herring, Saravana Kannan; +Cc: Linux-ALSA, devicetree

At least if rsnd is using DPCM connection with Audio-Graph-Card2,
fw_devlink might doesn't have enough information to break the cycle
(Same problem might occur with Multi-CPU/Codec or Codec2Codec).
In such case, rsnd driver will not be probed.
Add post-init-providers support to break the link cycle.

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
v1 -> v2
	- remove basic description/type
	- add detail description
	- update git-log

 Documentation/devicetree/bindings/sound/renesas,rsnd.yaml | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
index 07ec6247d9def..458877ce4aa42 100644
--- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
+++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
@@ -112,6 +112,13 @@ properties:
     description: List of necessary clock names.
     # details are defined below
 
+  post-init-providers:
+    description: |
+      At least if rsnd is using DPCM connection with Audio-Graph-Card2, fw_devlink might doesn't
+      have enough information to break the cycle. rsnd driver will not be probed in such case.
+      Add post-init-providers property to indicate which link in the cycle to break.
+      Same problem might occur with Multi-CPU/Codec or Codec2Codec.
+
   # ports is below
   port:
     $ref: audio-graph-port.yaml#/definitions/port-base
-- 
2.43.0


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2] ASoC: dt-bindings: renesas,rsnd: add post-init-providers property
  2024-09-04 23:44 [PATCH v2] ASoC: dt-bindings: renesas,rsnd: add post-init-providers property Kuninori Morimoto
@ 2024-09-09 14:22 ` Rob Herring
  0 siblings, 0 replies; 2+ messages in thread
From: Rob Herring @ 2024-09-09 14:22 UTC (permalink / raw)
  To: Kuninori Morimoto; +Cc: Mark Brown, Saravana Kannan, Linux-ALSA, devicetree

On Wed, Sep 04, 2024 at 11:44:08PM +0000, Kuninori Morimoto wrote:
> At least if rsnd is using DPCM connection with Audio-Graph-Card2,
> fw_devlink might doesn't have enough information to break the cycle
> (Same problem might occur with Multi-CPU/Codec or Codec2Codec).
> In such case, rsnd driver will not be probed.
> Add post-init-providers support to break the link cycle.
> 
> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> ---
> v1 -> v2
> 	- remove basic description/type
> 	- add detail description
> 	- update git-log
> 
>  Documentation/devicetree/bindings/sound/renesas,rsnd.yaml | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> index 07ec6247d9def..458877ce4aa42 100644
> --- a/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> +++ b/Documentation/devicetree/bindings/sound/renesas,rsnd.yaml
> @@ -112,6 +112,13 @@ properties:
>      description: List of necessary clock names.
>      # details are defined below
>  
> +  post-init-providers:
> +    description: |

Don't need '|' if there's no formatting.

> +      At least if rsnd is using DPCM connection with Audio-Graph-Card2, fw_devlink might doesn't
> +      have enough information to break the cycle. rsnd driver will not be probed in such case.

Wrap lines at 80, not 100 unless there's good reason to extend them.

> +      Add post-init-providers property to indicate which link in the cycle to break.

That describes every use of post-init-providers. Drop.

> +      Same problem might occur with Multi-CPU/Codec or Codec2Codec.
> +
>    # ports is below
>    port:
>      $ref: audio-graph-port.yaml#/definitions/port-base
> -- 
> 2.43.0
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2024-09-09 14:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-09-04 23:44 [PATCH v2] ASoC: dt-bindings: renesas,rsnd: add post-init-providers property Kuninori Morimoto
2024-09-09 14:22 ` Rob Herring

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox