Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Cezary Rojewski <cezary.rojewski@intel.com>
To: <alsa-devel@alsa-project.org>, <broonie@kernel.org>
Cc: pierre-louis.bossart@linux.intel.com, hdegoede@redhat.com,
	amadeuszx.slawinski@linux.intel.com, tiwai@suse.com
Subject: Re: [PATCH 00/17] ASoC: Intel: haswell and broadwell boards update
Date: Fri, 10 Jun 2022 19:33:08 +0200	[thread overview]
Message-ID: <2634f801-446e-04e0-89d6-5bee25dab109@intel.com> (raw)
In-Reply-To: <20220610123627.1339985-1-cezary.rojewski@intel.com>

On 2022-06-10 2:36 PM, Cezary Rojewski wrote:
> A number of patches improving overall quality and readability of
> haswell.c and broadwell.c source files found in sound/soc/intel/boards.
> Both files are first renamed and only then actual changes are being
> incrementally added. The respective names are: hsw_rt5640 and bdw_rt286
> to match the pattern found in more recent boards.
> 
> Most patches bring no functional change - the more impactful patches at
> are placed the end:
> 
> Refactor of suspend/resume flow for the bdw_rt286 board by dropping
> dev->remove() in favour of card->remove() and adjust jack handling to
> reduce code size slightly by implementing card_set_jack().
> 
> The last patch is removing of FE DAI ops. Given the existence of
> platform FE DAI capabilities (either static declaration or through
> topology file), this code is redundant.


Hello,

While this patchset reorganizes and rewords code of two boards in 
question, module (kernel module) names are unchanged. Currently those 
two are:

- snd_soc_sst_haswell.ko
- snd_soc_sst_broadwell.ko

My question is: Is it viable to reword these two?

Both modules accept no custom parameters, perhaps *dyndbg* is the only 
possibility so the impact is reduced.


Regards,
Czarek

  parent reply	other threads:[~2022-06-10 17:34 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-06-10 12:36 [PATCH 00/17] ASoC: Intel: haswell and broadwell boards update Cezary Rojewski
2022-06-10 12:36 ` [PATCH 01/17] ASoC: Intel: Rename haswell source file to hsw_rt5640 Cezary Rojewski
2022-06-10 12:36 ` [PATCH 02/17] ASoC: Intel: hsw_rt5640: Reword prefixes of all driver members Cezary Rojewski
2022-06-10 13:11   ` Cezary Rojewski
2022-06-10 12:36 ` [PATCH 03/17] ASoC: Intel: hsw_rt5640: Reword driver name Cezary Rojewski
2022-06-10 12:36 ` [PATCH 04/17] ASoC: Intel: hsw_rt5640: Update code indentation Cezary Rojewski
2022-06-10 12:36 ` [PATCH 05/17] ASoC: Intel: hsw_rt5640: Update file comments Cezary Rojewski
2022-06-10 12:36 ` [PATCH 06/17] ASoC: Intel: hsw_rt5640: Improve probe() function quality Cezary Rojewski
2022-06-10 12:36 ` [PATCH 07/17] ASoC: Intel: hsw_rt5640: Improve hw_params() debug-ability Cezary Rojewski
2022-06-10 12:36 ` [PATCH 08/17] ASoC: Intel: Rename broadwell source file to bdw_rt286 Cezary Rojewski
2022-06-10 12:36 ` [PATCH 09/17] ASoC: Intel: bdw_rt286: Reword prefixes of all driver members Cezary Rojewski
2022-06-10 16:34   ` Pierre-Louis Bossart
2022-06-10 17:25     ` Cezary Rojewski
2022-06-10 12:36 ` [PATCH 10/17] ASoC: Intel: bdw_rt286: Reword driver name Cezary Rojewski
2022-06-10 12:36 ` [PATCH 11/17] ASoC: Intel: bdw_rt286: Update code indentation Cezary Rojewski
2022-06-10 12:36 ` [PATCH 12/17] ASoC: Intel: bdw_rt286: Update file comments Cezary Rojewski
2022-06-10 12:36 ` [PATCH 13/17] ASoC: Intel: bdw_rt286: Improve probe() function quality Cezary Rojewski
2022-06-10 12:36 ` [PATCH 14/17] ASoC: Intel: bdw_rt286: Improve hw_params() debug-ability Cezary Rojewski
2022-06-10 12:36 ` [PATCH 15/17] ASoC: Intel: bdw_rt286: Improve codec_init() quality Cezary Rojewski
2022-06-10 12:36 ` [PATCH 16/17] ASoC: Intel: bdw_rt286: Refactor suspend/resume Cezary Rojewski
2022-06-10 12:36 ` [PATCH 17/17] ASoC: Intel: bdw_rt286: Remove FE DAI ops Cezary Rojewski
2022-06-10 17:33 ` Cezary Rojewski [this message]
2022-06-10 18:48   ` [PATCH 00/17] ASoC: Intel: haswell and broadwell boards update Pierre-Louis Bossart
2022-06-13  9:52     ` Cezary Rojewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2634f801-446e-04e0-89d6-5bee25dab109@intel.com \
    --to=cezary.rojewski@intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=amadeuszx.slawinski@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=hdegoede@redhat.com \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox