From: Cezary Rojewski <cezary.rojewski@intel.com>
To: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
<alsa-devel@alsa-project.org>, <broonie@kernel.org>
Cc: hdegoede@redhat.com, tiwai@suse.com, amadeuszx.slawinski@linux.intel.com
Subject: Re: [PATCH 09/17] ASoC: Intel: bdw_rt286: Reword prefixes of all driver members
Date: Fri, 10 Jun 2022 19:25:56 +0200 [thread overview]
Message-ID: <c677bd58-83df-3b73-c14c-0679cb827ce1@intel.com> (raw)
In-Reply-To: <59f2fd76-ac1e-9fdf-401b-2c09e5be8cc8@linux.intel.com>
On 2022-06-10 6:34 PM, Pierre-Louis Bossart wrote:
> On 6/10/22 07:36, Cezary Rojewski wrote:
>> Replace ambiguous 'broadwell_rt286_' prefixes in favour of 'card_',
>> 'link_' and other similar strings to clearly state which object given
>> member implements behavior for.
>>
>> Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
>> Reviewed-by: Amadeusz Sławiński <amadeuszx.slawinski@linux.intel.com>
>
> This doesn't apply or assumes something else was applied already?
I believe it conflicted with "ASoC: codecs: rt286: Reorganize jack
detect handling" [1] as that patch updates the users of
rt286_mic_detect(). That patch was just merged to
broonie/sound/for-next. Forgotten about those few lines being modified
there. Will update in v2.
[1]:
https://lore.kernel.org/alsa-devel/20220609133541.3984886-3-amadeuszx.slawinski@linux.intel.com/
Regards,
Czarek
next prev parent reply other threads:[~2022-06-10 17:27 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 12:36 [PATCH 00/17] ASoC: Intel: haswell and broadwell boards update Cezary Rojewski
2022-06-10 12:36 ` [PATCH 01/17] ASoC: Intel: Rename haswell source file to hsw_rt5640 Cezary Rojewski
2022-06-10 12:36 ` [PATCH 02/17] ASoC: Intel: hsw_rt5640: Reword prefixes of all driver members Cezary Rojewski
2022-06-10 13:11 ` Cezary Rojewski
2022-06-10 12:36 ` [PATCH 03/17] ASoC: Intel: hsw_rt5640: Reword driver name Cezary Rojewski
2022-06-10 12:36 ` [PATCH 04/17] ASoC: Intel: hsw_rt5640: Update code indentation Cezary Rojewski
2022-06-10 12:36 ` [PATCH 05/17] ASoC: Intel: hsw_rt5640: Update file comments Cezary Rojewski
2022-06-10 12:36 ` [PATCH 06/17] ASoC: Intel: hsw_rt5640: Improve probe() function quality Cezary Rojewski
2022-06-10 12:36 ` [PATCH 07/17] ASoC: Intel: hsw_rt5640: Improve hw_params() debug-ability Cezary Rojewski
2022-06-10 12:36 ` [PATCH 08/17] ASoC: Intel: Rename broadwell source file to bdw_rt286 Cezary Rojewski
2022-06-10 12:36 ` [PATCH 09/17] ASoC: Intel: bdw_rt286: Reword prefixes of all driver members Cezary Rojewski
2022-06-10 16:34 ` Pierre-Louis Bossart
2022-06-10 17:25 ` Cezary Rojewski [this message]
2022-06-10 12:36 ` [PATCH 10/17] ASoC: Intel: bdw_rt286: Reword driver name Cezary Rojewski
2022-06-10 12:36 ` [PATCH 11/17] ASoC: Intel: bdw_rt286: Update code indentation Cezary Rojewski
2022-06-10 12:36 ` [PATCH 12/17] ASoC: Intel: bdw_rt286: Update file comments Cezary Rojewski
2022-06-10 12:36 ` [PATCH 13/17] ASoC: Intel: bdw_rt286: Improve probe() function quality Cezary Rojewski
2022-06-10 12:36 ` [PATCH 14/17] ASoC: Intel: bdw_rt286: Improve hw_params() debug-ability Cezary Rojewski
2022-06-10 12:36 ` [PATCH 15/17] ASoC: Intel: bdw_rt286: Improve codec_init() quality Cezary Rojewski
2022-06-10 12:36 ` [PATCH 16/17] ASoC: Intel: bdw_rt286: Refactor suspend/resume Cezary Rojewski
2022-06-10 12:36 ` [PATCH 17/17] ASoC: Intel: bdw_rt286: Remove FE DAI ops Cezary Rojewski
2022-06-10 17:33 ` [PATCH 00/17] ASoC: Intel: haswell and broadwell boards update Cezary Rojewski
2022-06-10 18:48 ` Pierre-Louis Bossart
2022-06-13 9:52 ` Cezary Rojewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c677bd58-83df-3b73-c14c-0679cb827ce1@intel.com \
--to=cezary.rojewski@intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=hdegoede@redhat.com \
--cc=pierre-louis.bossart@linux.intel.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox