Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>, fntoth@gmail.com
Cc: alsa-devel@alsa-project.org, Takashi Iwai <tiwai@suse.de>,
	Hans de Goede <hdegoede@redhat.com>,
	vkoul@kernel.org, Mark Brown <broonie@kernel.org>,
	Dan Carpenter <dan.carpenter@oracle.com>
Subject: Re: [bug report] ASoC: Intel: mrfld - create separate module for pci part
Date: Fri, 3 Dec 2021 16:58:41 -0600	[thread overview]
Message-ID: <27281df2-5429-c9b0-8264-b030faa6a539@linux.intel.com> (raw)
In-Reply-To: <YaqA30mx4nUVdJoZ@smile.fi.intel.com>



>>> I would guess that indeed a return 0; is missing, but maybe it's time to
>>> remove this PCI code completely. I can't think of any user of the PCI
>>> parts of this driver.
>>>
>>> Andy, Hans, Mark, Takashi, what do you think?
>>
>> The Edison platform and actually some more based on Intel Merrifield are still
>> alive and on the (second hand) market. But yes, I would rather focus on making
>> SOF working there, but via PCI bus (or with ACPI, ASL code for which one should
>> actually write down, currently it's a device with PCI interface only).
> 
> That said, Pierre, have you been able to setup your Edison to see anything on
> I2S with SOF?

No, I haven't touched my Edison boards since the initial integration
with you and Ferry in 2020. I see that the firmware was updated to 1.8
and the kernel is 5.10+ now, so that should be easier than last time.
We don't really need any change for the driver probe, PCI is just fine,
what's missing is an ACPI recipe to enable audio functionality over the
SSP pins.

  reply	other threads:[~2021-12-03 22:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-03 10:13 [bug report] ASoC: Intel: mrfld - create separate module for pci part Dan Carpenter
2021-12-03 13:46 ` Pierre-Louis Bossart
2021-12-03 18:42   ` Mark Brown
2021-12-03 20:37   ` Andy Shevchenko
2021-12-03 20:41     ` Andy Shevchenko
2021-12-03 22:58       ` Pierre-Louis Bossart [this message]
2021-12-03 23:33         ` Ferry Toth
2021-12-03 20:39   ` Andy Shevchenko
2021-12-04 13:50   ` Hans de Goede

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27281df2-5429-c9b0-8264-b030faa6a539@linux.intel.com \
    --to=pierre-louis.bossart@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=broonie@kernel.org \
    --cc=dan.carpenter@oracle.com \
    --cc=fntoth@gmail.com \
    --cc=hdegoede@redhat.com \
    --cc=tiwai@suse.de \
    --cc=vkoul@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox