Alsa-Devel Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v2 3/3] ASoC: rt715: modification for code simplicity
@ 2021-03-29  6:54 Jack Yu
  2021-04-16 18:34 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Jack Yu @ 2021-03-29  6:54 UTC (permalink / raw)
  To: broonie@kernel.org, lgirdwood@gmail.com
  Cc: Oder Chiou, Jack Yu, alsa-devel@alsa-project.org, lars@metafoo.de,
	Derek [方德義], bard.liao@intel.com,
	Shuming [范書銘], Flove(HsinFu),
	pierre-louis.bossart@intel.com

[-- Attachment #1: Type: text/plain, Size: 1235 bytes --]

Modification for code simplicity.

Signed-off-by: Jack Yu <jack.yu@realtek.com>
---
 sound/soc/codecs/rt715.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/sound/soc/codecs/rt715.c b/sound/soc/codecs/rt715.c
index b33eabb9f740..1352869cc086 100644
--- a/sound/soc/codecs/rt715.c
+++ b/sound/soc/codecs/rt715.c
@@ -57,14 +57,14 @@ static void rt715_get_gain(struct rt715_priv *rt715, unsigned int addr_h,
 {
 	int ret;
 	/* R Channel */
-	*r_val = (val_h << 8);
+	*r_val = val_h << 8;
 	ret = regmap_read(rt715->regmap, addr_l, r_val);
 	if (ret < 0)
 		pr_err("Failed to get R channel gain.\n");
 
 	/* L Channel */
 	val_h |= 0x20;
-	*l_val = (val_h << 8);
+	*l_val = val_h << 8;
 	ret = regmap_read(rt715->regmap, addr_h, l_val);
 	if (ret < 0)
 		pr_err("Failed to get L channel gain.\n");
@@ -183,8 +183,8 @@ static int rt715_set_amp_gain_get(struct snd_kcontrol *kcontrol,
 
 	if (mc->invert) {
 		/* for mute status */
-		read_ll = !((read_ll & 0x80) >> RT715_MUTE_SFT);
-		read_rl = !((read_rl & 0x80) >> RT715_MUTE_SFT);
+		read_ll = !(read_ll & 0x80);
+		read_rl = !(read_rl & 0x80);
 	} else {
 		/* for gain */
 		read_ll = read_ll & 0x7f;
-- 
2.29.0


[-- Attachment #2: winmail.dat --]
[-- Type: application/ms-tnef, Size: 5209 bytes --]

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH v2 3/3] ASoC: rt715: modification for code simplicity
  2021-03-29  6:54 [PATCH v2 3/3] ASoC: rt715: modification for code simplicity Jack Yu
@ 2021-04-16 18:34 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2021-04-16 18:34 UTC (permalink / raw)
  To: lgirdwood, Jack Yu
  Cc: Oder Chiou, alsa-devel, lars, Mark Brown,
	Derek [方德義], Flove(HsinFu),
	Shuming [范書銘], bard.liao,
	pierre-louis.bossart

On Mon, 29 Mar 2021 06:54:05 +0000, Jack Yu wrote:
> Modification for code simplicity.

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[3/3] ASoC: rt715: modification for code simplicity
      commit: a48f928e13a01d60c9c2a7a7ffab3afd1f7337bf

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-04-16 18:36 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-03-29  6:54 [PATCH v2 3/3] ASoC: rt715: modification for code simplicity Jack Yu
2021-04-16 18:34 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox