Re: [PATCH] Enable SPDIF output on Intel Hades Canyon

[Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>]

On 5/23/22 15:20, Dag B wrote:
> Without the attached patch, the s/pdif output on the Hades Canyon NUC
> does not work.
> 
> "Well known" issue, less known fix. As far as I can tell, there is no
> risk of any averse side-effects. But a bonus fix is enabling on-wire
> headset microphone, by chaining the right 'model' choice for the hardware.
> 
> If I should Cc: someone directly for this patch to be picked up, please
> let me know.
> 
> 
> I have been running with this patch for half a year or so.
> 
> Patch passes checkpatch.pl
> 
> Patch is based on what 'cyber4o' posted on the insanelymac forum [1].
> All the glory to this person, any error is likely mine.

Thanks for the patch.

You would need a Signed-off-by tag for this patch, and CC: Takashi (added)

+	[ALC700_FIXUP_NUC_SPDIF] = {

Maybe use HC_NUC, there are multiple versions of those devices?

+		.type = HDA_FIXUP_FUNC,
+		.v.func = alc700_fixup_nuc_spdif,

alc700_fixup_hc_nuc_spdif ?

+		.chained = true,
+		.chain_id = ALC269_FIXUP_DELL1_MIC_NO_PRESENCE,

that chain_id doesn't seem quite right?


> 
> Some other users with issues: [2] [3]
> 
> 
> Dag Bakke
> 
> 
> [1]
> https://www.insanelymac.com/forum/topic/339291-guide-hac-mini-osx-mojave-on-intel-hades-canyon-nuc8i7hvknuc8i7hnk/page/8/
> 
> 
> 2] https://bbs.archlinux.org/viewtopic.php?id=270917
> 
> [3]
> https://www.reddit.com/r/intelnuc/comments/9ft9x8/any_linux_users_got_the_spdif_toslink_to_work_on/
> 
> 
>