Re: [PATCH] Enable SPDIF output on Intel Hades Canyon

[Takashi Iwai <tiwai@suse.de>]

On Tue, 24 May 2022 08:58:30 +0200,
Dag B wrote:
> From fe562e391b522dca09f00a5f8c280ab43136ef1f Mon Sep 17 00:00:00 2001
> From: Dag B <dag@bakke.com>
> Date: Tue, 24 May 2022 08:38:42 +0200
> Subject: [PATCH] Enable Intel Hades Canyon SPDIF
> 
> Signed-off-by: Dag B <dag@bakke.com>

Please give more description, especially why this patch is needed and
what actually does.

About the code change:


> ---
>  sound/pci/hda/patch_realtek.c | 17 ++++++++++++++++-
>  1 file changed, 16 insertions(+), 1 deletion(-)
> 
> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> index ad292df7d805..cd6a2cb4c381 100644
> --- a/sound/pci/hda/patch_realtek.c
> +++ b/sound/pci/hda/patch_realtek.c
> @@ -4752,6 +4752,12 @@ static void alc280_fixup_hp_gpio2_mic_hotkey(struct hda_codec *codec,
>  	}
>  }
>  
> +static void alc700_fixup_hc_nuc_spdif(struct hda_codec *codec,
> +				const struct hda_fixup *fix, int action)
> +{
> +	snd_hda_override_wcaps(codec, 0x6, 0x611);

Better to be the values with AC_WCAP_*.


> @@ -5792,7 +5798,7 @@ static void alc_fixup_headset_mode_alc255_no_hp_mic(struct hda_codec *codec,
>  		struct alc_spec *spec = codec->spec;
>  		spec->parse_flags |= HDA_PINCFG_HEADSET_MIC;
>  		alc255_set_default_jack_type(codec);
> -	} 
> +	}
>  	else
>  		alc_fixup_headset_mode(codec, fix, action);
>  }

Avoid unnecessary changes like this.


> @@ -9159,6 +9172,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = {
>  	SND_PCI_QUIRK(0x10cf, 0x1757, "Lifebook E752", ALC269_FIXUP_LIFEBOOK_HP_PIN),
>  	SND_PCI_QUIRK(0x10cf, 0x1845, "Lifebook U904", ALC269_FIXUP_LIFEBOOK_EXTMIC),
>  	SND_PCI_QUIRK(0x10ec, 0x10f2, "Intel Reference board", ALC700_FIXUP_INTEL_REFERENCE),
> +	SND_PCI_QUIRK(0x10ec, 0x2073, "Intel NUC8 Hades Canyon", ALC700_FIXUP_HC_NUC_SPDIF),

So this is about the generic ID (with Realtek vendor-id).
It's most likely OK, as such an ID is used only for some reference
board or such, but it should be mentioned in the changelog.

> @@ -9445,6 +9459,7 @@ static const struct hda_model_fixup alc269_fixup_models[] = {
>  	{.id = ALC298_FIXUP_TPT470_DOCK, .name = "tpt470-dock"},
>  	{.id = ALC233_FIXUP_LENOVO_MULTI_CODECS, .name = "dual-codecs"},
>  	{.id = ALC700_FIXUP_INTEL_REFERENCE, .name = "alc700-ref"},
> +	{.id = ALC700_FIXUP_HC_NUC_SPDIF, .name = "nuc-hc"},

Ditto, better to mention the available model name in the changelog,
too.

Once after all those are fixed / improved, please resubmit the patch.


thanks,

Takashi